Skip to content

Fix newlines in PR bot reply #54803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Jun 27, 2023

I tested these string concats... in zsh, not realizing that bash would not behave the same way. Fix this by putting the newlines into a $'' string which does support escaping.

#54788 (comment)

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 27, 2023
@jakebailey jakebailey merged commit 5b5a139 into microsoft:main Jun 27, 2023
@jakebailey jakebailey deleted the fix-pr-comment-newlines branch June 27, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants