Update Array#forEach: use a generic type parameter to ensure elements are inferred correctly #55202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type are inferred correctly
typescript-bot
added
the
For Uncommitted Bug
MartinJohns
reviewed
Jul 29, 2023
| @@ -1237,7 +1237,7 @@ interface ReadonlyArray<T> { | |||
| * @param callbackfn A function that accepts up to three arguments. forEach calls the callbackfn function one time for each element in the array. | |||
| * @param thisArg An object to which the this keyword can refer in the callbackfn function. If thisArg is omitted, undefined is used as the this value. | |||
| */ | |||
| forEach(callbackfn: (value: T, index: number, array: readonly T[]) => void, thisArg?: any): void; | |||
| forEach<U>(callbackfn: (value: T, index: number, array: readonly T[]) => void, thisArg?: any): void; | |||
There was a problem hiding this comment.
The type argument isn't used anywhere.
|
See #16223, where the generic argument for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55201