Return all symbols in navto for empty string pattern #55550

gabritto · 2023-08-28T18:16:35Z

DanielRosenwasser · 2023-08-28T18:46:53Z

Does navto do an after-the-fact filter today? Or does it filter as it aggregates symbols? Also curious if you've tried this on slightly bigger codebases like VS Code or TypeScript itself (for both Go To Symbol in Editor and Go To Symbol in Workspace).

gabritto · 2023-08-28T19:14:18Z

Does navto do an after-the-fact filter today? Or does it filter as it aggregates symbols? Also curious if you've tried this on slightly bigger codebases like VS Code or TypeScript itself (for both Go To Symbol in Editor and Go To Symbol in Workspace).

Do you mean if vscode is going to filter the navto results TS Server sends? If so, it doesn't. I'll wait to merge this until we decide on the changes needed on the editor side.

gabritto · 2023-08-28T19:17:24Z

We might also want to consider doing #48194, but I don't know what was discussed/decided about it the last time it was brought up.

gabritto · 2023-08-28T19:17:40Z

@typescript-bot perf test this

typescript-bot · 2023-08-28T19:17:42Z

Heya @gabritto, I've started to run the regular perf test suite on this PR at 8d43af7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-28T19:48:13Z

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,256k (± 0.00%)}	_{300,264k (± 0.01%)}	_~	_300,242k	_300,297k	_{p=0.630 n=6}
_{Parse Time}	_{3.03s (± 0.49%)}	_{3.03s (± 0.13%)}	_~	_3.03s	_3.04s	_{p=1.000 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.28s (± 0.16%)}	_{9.28s (± 0.26%)}	_~	_9.25s	_9.32s	_{p=0.739 n=6}
_{Emit Time}	_{7.62s (± 0.39%)}	_{7.62s (± 0.10%)}	_~	_7.61s	_7.63s	_{p=1.000 n=6}
_{Total Time}	_{20.86s (± 0.21%)}	_{20.87s (± 0.12%)}	_~	_20.84s	_20.91s	_{p=0.809 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,934k (± 0.02%)}	_{194,458k (± 0.66%)}	_~	_193,888k	_197,096k	_{p=0.630 n=6}
_{Parse Time}	_{1.58s (± 0.33%)}	_{1.58s (± 0.33%)}	_~	_1.58s	_1.59s	_{p=1.000 n=6}
_{Bind Time}	_{0.80s (± 0.00%)}	_{0.80s (± 0.00%)}	_~	_0.80s	_0.80s	_{p=1.000 n=6}
_{Check Time}	_{9.91s (± 0.50%)}	_{9.93s (± 0.78%)}	_~	_9.84s	_10.05s	_{p=0.936 n=6}
_{Emit Time}	_{2.74s (± 0.27%)}	_{2.74s (± 0.15%)}	_~	_2.73s	_2.74s	_{p=0.389 n=6}
_{Total Time}	_{15.03s (± 0.37%)}	_{15.05s (± 0.52%)}	_~	_14.96s	_15.17s	_{p=0.872 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,148k (± 0.01%)}	_{347,140k (± 0.01%)}	_~	_347,079k	_347,181k	_{p=0.873 n=6}
_{Parse Time}	_{2.69s (± 0.31%)}	_{2.69s (± 0.23%)}	_~	_2.68s	_2.70s	_{p=0.226 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.41%)}	_~	_0.98s	_0.99s	_{p=0.405 n=6}
_{Check Time}	_{7.90s (± 0.12%)}	_{7.91s (± 0.21%)}	_~	_7.89s	_7.94s	_{p=0.437 n=6}
_{Emit Time}	_{4.26s (± 0.38%)}	_{4.25s (± 0.32%)}	_~	_4.24s	_4.27s	_{p=0.804 n=6}
_{Total Time}	_{15.83s (± 0.14%)}	_{15.84s (± 0.20%)}	_~	_15.79s	_15.88s	_{p=0.686 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,153k (± 0.00%)}	_{301,157k (± 0.00%)}	_~	_301,128k	_301,166k	_{p=0.261 n=6}
_{Parse Time}	_{2.18s (± 0.56%)}	_{2.18s (± 0.58%)}	_~	_2.16s	_2.19s	_{p=0.452 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.00%)}	_~	_1.11s	_1.11s	_{p=0.174 n=6}
_{Check Time}	_{7.23s (± 0.34%)}	_{7.22s (± 0.38%)}	_~	_7.20s	_7.26s	_{p=0.514 n=6}
_{Emit Time}	_{3.99s (± 0.19%)}	_{3.98s (± 0.49%)}	_~	_3.95s	_4.01s	_{p=0.118 n=6}
_{Total Time}	_{14.51s (± 0.23%)}	_{14.49s (± 0.27%)}	_~	_14.45s	_14.56s	_{p=0.366 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,463k (± 0.00%)}	_{479,467k (± 0.00%)}	_~	_479,443k	_479,479k	_{p=0.470 n=6}
_{Parse Time}	_{3.15s (± 0.20%)}	_{3.15s (± 0.24%)}	_~	_3.14s	_3.16s	_{p=0.718 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.76s (± 0.23%)}	_{17.77s (± 0.34%)}	_~	_17.66s	_17.84s	_{p=0.747 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.82s (± 0.21%)}	_{21.82s (± 0.30%)}	_~	_21.71s	_21.91s	_{p=0.687 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,833k (± 0.01%)}	_{542,848k (± 0.01%)}	_~	_542,782k	_542,957k	_{p=0.936 n=6}
_{Parse Time}	_{3.70s (± 0.24%)}	_{3.70s (± 0.32%)}	_~	_3.69s	_3.72s	_{p=0.672 n=6}
_{Bind Time}	_{1.40s (± 4.57%)}	_{1.44s (± 3.40%)}	_~	_1.34s	_1.46s	_{p=0.144 n=6}
_{Check Time}	_{3.23s (± 2.97%)}	_{3.18s (± 2.04%)}	_~	_3.13s	_3.31s	_{p=0.685 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.42s (± 0.38%)}	_{8.40s (± 0.37%)}	_~	_8.38s	_8.46s	_{p=0.465 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,493ms (± 0.12%)}	_{2,490ms (± 0.20%)}	_~	_2,484ms	_2,496ms	_{p=0.746 n=6}
_{Req 2 - geterr}	_{5,933ms (± 0.20%)}	_{5,941ms (± 0.11%)}	_~	_5,934ms	_5,950ms	_{p=0.172 n=6}
_{Req 3 - references}	_{344ms (± 0.44%)}	_{343ms (± 0.45%)}	_~	_342ms	_346ms	_{p=0.502 n=6}
_{Req 4 - navto}	_{278ms (± 0.84%)}	_{277ms (± 0.15%)}	_~	_276ms	_277ms	_{p=0.056 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 8.65%)}	_{88ms (± 8.55%)}	_~	_76ms	_94ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,615ms (± 0.19%)}	_{2,627ms (± 0.43%)}	_~	_2,612ms	_2,639ms	_{p=0.077 n=6}
_{Req 2 - geterr}	_{4,766ms (± 0.34%)}	_{4,769ms (± 0.15%)}	_~	_4,762ms	_4,780ms	_{p=0.936 n=6}
_{Req 3 - references}	_{352ms (± 0.82%)}	_{350ms (± 0.12%)}	_~	_350ms	_351ms	_{p=0.474 n=6}
_{Req 4 - navto}	_{270ms (± 0.41%)}	_{269ms (± 0.56%)}	_~	_267ms	_271ms	_{p=0.451 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.52%)}	_{78ms (± 3.01%)}	_~	_73ms	_79ms	_{p=0.248 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,714ms (± 0.23%)}	_{2,714ms (± 0.17%)}	_~	_2,709ms	_2,721ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,929ms (± 2.74%)}	_{1,935ms (± 1.96%)}	_~	_1,884ms	_1,968ms	_{p=0.936 n=6}
_{Req 3 - references}	_{137ms (± 2.05%)}	_{135ms (± 2.34%)}	_~	_132ms	_141ms	_{p=0.371 n=6}
_{Req 4 - navto}	_{353ms (± 0.44%)}	_{353ms (± 0.21%)}	_~	_352ms	_354ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{317ms (± 1.93%)}	_{317ms (± 1.76%)}	_~	_312ms	_327ms	_{p=0.868 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{156.25ms (± 0.22%)}	_{156.21ms (± 0.19%)}	_~	_154.45ms	_158.48ms	_{p=0.065 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.25ms (± 0.13%)}	_{231.03ms (± 0.14%)}	_{+0.78ms (+ 0.34%)}	_229.45ms	_235.14ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{234.89ms (± 0.12%)}	_{236.12ms (± 0.14%)}	_{+1.22ms (+ 0.52%)}	_234.68ms	_242.06ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{236.37ms (± 0.16%)}	_{236.17ms (± 0.13%)}	_{-0.20ms (- 0.08%)}	_233.76ms	_240.28ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

gabritto · 2023-08-28T20:03:53Z

@gabritto The results of the perf run you requested are in!

Here they are:

I just remembered the benchmark sends a navto request with some pre-defined string... So the perf tests are not relevant here. But I tested this locally and there isn't a delay on the vscode codebase, but for the TS codebase there's a ~1.5s delay between the command and the results showing up.

DanielRosenwasser · 2023-08-28T20:41:06Z

No, I was asking if it's the case that running navTo with "getTypeFrom" will walk across the whole project and then filter the symbols based on getTypeFrom, or if the filtering is done during the walk itself.

gabritto · 2023-08-28T20:51:17Z

No, I was asking if it's the case that running navTo with "getTypeFrom" will walk across the whole project and then filter the symbols based on getTypeFrom, or if the filtering is done during the walk itself.

It'll walk across all files in all the projects, collect all named declarations (if they haven't been computed yet), and then look at every named declaration to see if it matches "getTypeFrom".
So yes, the filtering is done after-the-fact.

gabritto · 2023-08-30T22:30:12Z

Update: I did some perf testing locally of how long it takes for TS Server to process navto request in the TS codebase with no search of empty string vs. a single letter "a" vs. "node".

The first ever navto request takes a long time (0.5s for me), because the named declarations of each file are not cached yet, but other than that:

"" takes ~0.115s
"a" takes ~0.112s
"node" takes ~0.8s

So overall I think this looks acceptable as-is.

At first I thought this empty string search was a bit slow because I was testing it on vscode directly, and there seems to be an added delay on vscode that is at times inconsistent, but at least to me it shows up not only for the empty string search, but for other navto searches as well. So I think this is no worse than what we have today.

gabritto added 3 commits August 25, 2023 18:27

add test

cf2a873

support empty string in navto

de5ef57

fix tests

8d43af7

typescript-bot assigned gabritto Aug 28, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 28, 2023

gabritto requested review from DanielRosenwasser and andrewbranch August 28, 2023 18:45

andrewbranch approved these changes Aug 28, 2023

View reviewed changes

gabritto merged commit cbadc78 into main Aug 30, 2023

gabritto deleted the gabritto/issue55483 branch August 30, 2023 22:30

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Return all symbols in navto for empty string pattern (microsoft#55550)

c88880f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Return all symbols in navto for empty string pattern #55550

Return all symbols in navto for empty string pattern #55550

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

DanielRosenwasser commented Aug 28, 2023 •

edited

Loading

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

typescript-bot commented Aug 28, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Aug 28, 2023

Compiler

tsserver

Startup

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

DanielRosenwasser commented Aug 28, 2023

Uh oh!

gabritto commented Aug 28, 2023 •

edited

Loading

Uh oh!

gabritto commented Aug 30, 2023

Uh oh!

Uh oh!

Return all symbols in navto for empty string pattern #55550

Return all symbols in navto for empty string pattern #55550

Uh oh!

Conversation

gabritto commented Aug 28, 2023

Uh oh!

DanielRosenwasser commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

typescript-bot commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 28, 2023

Compiler

tsserver

Startup

Uh oh!

gabritto commented Aug 28, 2023

Uh oh!

DanielRosenwasser commented Aug 28, 2023

Uh oh!

gabritto commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabritto commented Aug 30, 2023

Uh oh!

Uh oh!

DanielRosenwasser commented Aug 28, 2023 •

edited

Loading

typescript-bot commented Aug 28, 2023 •

edited

Loading

gabritto commented Aug 28, 2023 •

edited

Loading