Add option to exclude library symbols from navTo results #55605
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
| @@ -579,14 +589,13 @@ export class SessionClient implements LanguageService { | |||
| const providePrefixAndSuffixTextForRename = typeof preferences === "boolean" ? preferences : preferences?.providePrefixAndSuffixTextForRename; | |||
| const quotePreference = typeof preferences === "boolean" ? undefined : preferences?.quotePreference; | |||
| if (providePrefixAndSuffixTextForRename !== undefined || quotePreference !== undefined) { | |||
| const oldPreferences = this.preferences; | |||
There was a problem hiding this comment.
The other diffs in the file were just a drive-by fix to how we restore preferences for the harness client. I think we don't have tests that observe this though.
Fixes #48194.
I'll follow up with an equivalent setting in vscode.