Fix issue #5444 #5566
Merged
Fix issue #5444 #5566
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reportImplementationExpectedError: The next node in the tree is not
necessarily consecutive. This happens due to syntax errors, e.g.
class C { foo(), foo(); }
|
Hi @jeffreymorlan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Can you please add unit tests. |
|
To be clear, @mhegazy does't mean a unit test, he means an end-to-end test. Check out Adding a Test in our CONTRIBUTING.md. |
| @@ -11205,7 +11205,7 @@ namespace ts { | |||
| seen = c === node; | |||
| } | |||
| }); | |||
| if (subsequentNode) { | |||
| if (subsequentNode && subsequentNode.pos === node.end) { | |||
There was a problem hiding this comment.
Can you add a comment that you need this test because garbage declarations may be introduced between overloads and cause issues according to our expectations
|
👍 @vladima could you take a look? |
|
👍 after @DanielRosenwasser note about the comment is addressed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reportImplementationExpectedError: The next node in the tree is not
necessarily consecutive. This happens due to syntax errors, e.g.
Edit by @DanielRosenwasser: Fixes #5444