fix(55899): Indexing/element access on super avoids instance property checks #55903

a-tarasyuk · 2023-09-28T17:30:25Z

DanielRosenwasser · 2023-09-28T18:33:39Z

If my memory serves me right, indexed accesses might've been an escape hatch to opt out of visibility modifiers. Maybe @RyanCavanaugh remembers better.

That said, let's see how this works

@typescript-bot perf test this
@typescript-bot test top200

typescript-bot · 2023-09-28T18:33:44Z

Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at 53a4088. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-28T18:33:44Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 53a4088. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-28T18:55:28Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,004k (± 0.01%)}	_{295,027k (± 0.01%)}	_~	_294,978k	_295,070k	_{p=0.298 n=6}
_{Parse Time}	_{2.64s (± 0.37%)}	_{2.64s (± 0.31%)}	_~	_2.63s	_2.65s	_{p=0.862 n=6}
_{Bind Time}	_{0.84s (± 0.90%)}	_{0.84s (± 1.30%)}	_~	_0.83s	_0.85s	_{p=0.865 n=6}
_{Check Time}	_{8.07s (± 0.33%)}	_{8.07s (± 0.41%)}	_~	_8.02s	_8.11s	_{p=0.935 n=6}
_{Emit Time}	_{7.04s (± 0.36%)}	_{7.04s (± 0.42%)}	_~	_7.01s	_7.08s	_{p=0.809 n=6}
_{Total Time}	_{18.59s (± 0.11%)}	_{18.59s (± 0.28%)}	_~	_18.51s	_18.65s	_{p=0.872 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,600k (± 1.66%)}	_{191,662k (± 1.24%)}	_~	_190,652k	_196,535k	_{p=0.471 n=6}
_{Parse Time}	_{1.34s (± 0.99%)}	_{1.35s (± 1.15%)}	_~	_1.34s	_1.38s	_{p=0.491 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.15s (± 0.57%)}	_{9.18s (± 0.82%)}	_~	_9.10s	_9.31s	_{p=0.872 n=6}
_{Emit Time}	_{2.64s (± 0.65%)}	_{2.63s (± 0.34%)}	_~	_2.62s	_2.64s	_{p=0.284 n=6}
_{Total Time}	_{13.87s (± 0.41%)}	_{13.89s (± 0.61%)}	_~	_13.82s	_14.04s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,238k (± 0.01%)}	_{347,217k (± 0.01%)}	_~	_347,193k	_347,249k	_{p=0.335 n=6}
_{Parse Time}	_{2.46s (± 0.50%)}	_{2.45s (± 0.31%)}	_~	_2.44s	_2.46s	_{p=0.796 n=6}
_{Bind Time}	_{0.94s (± 0.67%)}	_{0.94s (± 0.43%)}	_~	_0.94s	_0.95s	_{p=0.673 n=6}
_{Check Time}	_{6.86s (± 0.53%)}	_{6.86s (± 0.38%)}	_~	_6.83s	_6.90s	_{p=1.000 n=6}
_{Emit Time}	_{4.01s (± 0.34%)}	_{4.02s (± 0.34%)}	_~	_4.01s	_4.05s	_{p=0.241 n=6}
_{Total Time}	_{14.28s (± 0.24%)}	_{14.28s (± 0.27%)}	_~	_14.23s	_14.34s	_{p=1.000 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,550k (± 0.01%)}	_{302,542k (± 0.01%)}	_~	_302,509k	_302,611k	_{p=1.000 n=6}
_{Parse Time}	_{1.98s (± 0.21%)}	_{2.00s (± 1.07%)}	_~	_1.97s	_2.02s	_{p=0.077 n=6}
_{Bind Time}	_{1.01s (± 0.80%)}	_{1.01s (± 1.20%)}	_~	_0.99s	_1.02s	_{p=0.354 n=6}
_{Check Time}	_{6.26s (± 0.45%)}	_{6.26s (± 0.48%)}	_~	_6.22s	_6.30s	_{p=0.935 n=6}
_{Emit Time}	_{3.52s (± 0.66%)}	_{3.55s (± 0.74%)}	_~	_3.53s	_3.59s	_{p=0.090 n=6}
_{Total Time}	_{12.78s (± 0.20%)}	_{12.82s (± 0.50%)}	_~	_12.74s	_12.90s	_{p=0.257 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,501k (± 0.01%)}	_{470,474k (± 0.00%)}	_~	_470,454k	_470,493k	_{p=0.091 n=6}
_{Parse Time}	_{2.57s (± 0.43%)}	_{2.56s (± 0.48%)}	_~	_2.55s	_2.58s	_{p=0.731 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{0.99s (± 0.82%)}	_~	_0.98s	_1.00s	_{p=0.498 n=6}
_{Check Time}	_{16.57s (± 0.33%)}	_{16.64s (± 0.47%)}	_~	_16.57s	_16.79s	_{p=0.147 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.14s (± 0.26%)}	_{20.20s (± 0.36%)}	_~	_20.12s	_20.33s	_{p=0.146 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,570k (± 0.02%)}	_{512,595k (± 0.02%)}	_~	_512,455k	_512,686k	_{p=0.630 n=6}
_{Parse Time}	_{3.27s (± 0.36%)}	_{3.27s (± 0.32%)}	_~	_3.26s	_3.29s	_{p=1.000 n=6}
_{Bind Time}	_{1.54s (± 0.35%)}	_{1.55s (± 0.53%)}	_~	_1.54s	_1.56s	_{p=0.859 n=6}
_{Check Time}	_{2.85s (± 0.96%)}	_{2.85s (± 0.97%)}	_~	_2.81s	_2.89s	_{p=0.809 n=6}
_{Emit Time}	_{0.08s (± 6.73%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.174 n=6}
_{Total Time}	_{7.74s (± 0.42%)}	_{7.75s (± 0.35%)}	_~	_7.71s	_7.78s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,371ms (± 1.09%)}	_{2,354ms (± 1.21%)}	_~	_2,326ms	_2,392ms	_{p=0.297 n=6}
_{Req 2 - geterr}	_{5,350ms (± 1.51%)}	_{5,373ms (± 1.78%)}	_~	_5,278ms	_5,473ms	_{p=1.000 n=6}
_{Req 3 - references}	_{326ms (± 0.27%)}	_{327ms (± 0.55%)}	_~	_325ms	_330ms	_{p=0.363 n=6}
_{Req 4 - navto}	_{276ms (± 0.90%)}	_{277ms (± 1.49%)}	_~	_271ms	_282ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 9.69%)}	_{82ms (±10.23%)}	_~	_74ms	_90ms	_{p=0.557 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,478ms (± 1.45%)}	_{2,470ms (± 0.88%)}	_~	_2,447ms	_2,508ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,104ms (± 1.98%)}	_{4,103ms (± 2.00%)}	_~	_4,041ms	_4,224ms	_{p=0.810 n=6}
_{Req 3 - references}	_{338ms (± 1.52%)}	_{338ms (± 1.49%)}	_~	_331ms	_344ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{284ms (± 0.29%)}	_{284ms (± 0.22%)}	_~	_283ms	_285ms	_{p=0.432 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.32%)}	_{80ms (± 7.36%)}	_~	_75ms	_87ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,594ms (± 0.42%)}	_{2,592ms (± 0.41%)}	_~	_2,583ms	_2,607ms	_{p=0.628 n=6}
_{Req 2 - geterr}	_{1,700ms (± 2.41%)}	_{1,699ms (± 2.41%)}	_~	_1,633ms	_1,737ms	_{p=0.810 n=6}
_{Req 3 - references}	_{119ms (± 8.16%)}	_{112ms (± 7.95%)}	_~	_105ms	_125ms	_{p=0.124 n=6}
_{Req 4 - navto}	_{360ms (± 0.41%)}	_{360ms (± 0.60%)}	_~	_358ms	_364ms	_{p=0.196 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 2.20%)}	_{310ms (± 1.68%)}	_~	_302ms	_316ms	_{p=0.198 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.06ms (± 0.17%)}	_{152.03ms (± 0.17%)}	_~	_151.00ms	_156.33ms	_{p=0.256 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.87ms (± 0.16%)}	_{227.78ms (± 0.17%)}	_{-0.09ms (- 0.04%)}	_226.46ms	_234.23ms	_{p=0.002 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.89ms (± 0.17%)}	_{228.90ms (± 0.19%)}	_~	_227.09ms	_235.33ms	_{p=0.977 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.97ms (± 0.19%)}	_{228.85ms (± 0.15%)}	_{-0.12ms (- 0.05%)}	_227.50ms	_232.46ms	_{p=0.011 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-28T20:52:24Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/55903/merge:

Something interesting changed - please have a look.

Details

apollographql/apollo-client

1 of 10 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2446: Property 'lookup' is protected and only accessible through an instance of class 'Layer'. This is an instance of class 'EntityStore'.
- src/cache/inmemory/entityStore.ts#L693
error TS2341: Property 'data' is private and only accessible within class 'InMemoryCache'.
- src/cache/inmemory/policies.ts#L390
error TS2341: Property 'updateWatch' is private and only accessible within class 'QueryInfo'.
- src/core/ObservableQuery.ts#L258
error TS2341: Property 'fetchConcastWithInfo' is private and only accessible within class 'QueryManager<TStore>'.
- src/core/ObservableQuery.ts#L737
error TS2341: Property 'notifyTimeout' is private and only accessible within class 'QueryInfo'.
error TS2341: Property 'queryInfo' is private and only accessible within class 'ObservableQuery<TData, TVariables>'.
- src/core/QueryInfo.ts#L230
- src/core/QueryManager.ts#L1458
error TS2341: Property 'observe' is private and only accessible within class 'ObservableQuery<TData, TVariables>'.
- src/core/QueryInfo.ts#L240
error TS2341: Property 'lastQuery' is private and only accessible within class 'ObservableQuery<TData, TVariables>'.
- src/core/QueryManager.ts#L734
error TS2341: Property 'applyNextFetchPolicy' is private and only accessible within class 'ObservableQuery<TData, TVariables>'.
- src/core/QueryManager.ts#L1269
error TS2341: Property 'getFragmentDoc' is private and only accessible within class 'ApolloCache<TSerialized>'.
- src/react/hooks/useFragment.ts#L55
error TS2341: Property 'queryRefs' is private and only accessible within class 'SuspenseCache'.
- src/testing/matchers/toHaveSuspenseCacheEntryUsing.ts#L33

discordjs/discord.js

37 of 57 projects failed to build with the old tsc and were ignored

packages/voice/tsconfig.docs.json

error TS2341: Property '_stepDispatch' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/DataStore.ts#L124
error TS2341: Property '_stepPrepare' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/DataStore.ts#L146
error TS2341: Property 'subscribe' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/VoiceConnection.ts#L662
error TS2445: Property 'onSubscriptionRemoved' is protected and only accessible within class 'VoiceConnection' and its subclasses.
- packages/voice/src/audio/PlayerSubscription.ts#L30
error TS2341: Property 'unsubscribe' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/audio/PlayerSubscription.ts#L31

packages/voice/tsconfig.json

error TS2341: Property '_stepDispatch' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/DataStore.ts#L124
error TS2341: Property '_stepPrepare' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/DataStore.ts#L146
error TS2341: Property 'subscribe' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/VoiceConnection.ts#L662
error TS2445: Property 'onSubscriptionRemoved' is protected and only accessible within class 'VoiceConnection' and its subclasses.
- packages/voice/src/audio/PlayerSubscription.ts#L30
error TS2341: Property 'unsubscribe' is private and only accessible within class 'AudioPlayer'.
- packages/voice/src/audio/PlayerSubscription.ts#L31

Eugeny/tabby

9 of 29 projects failed to build with the old tsc and were ignored

tabby-community-color-schemes/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-core/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-core/tsconfig.typings.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-electron/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-linkifier/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-local/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-plugin-manager/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-serial/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-settings/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-ssh/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-telnet/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-terminal/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-web-demo/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

tabby-web/tsconfig.json

error TS2341: Property '_group' is private and only accessible within class 'CdkDropList<T>'.
- tabby-core/src/directives/cdkAutoDropGroup.directive.ts#L25

immich-app/immich

4 of 6 projects failed to build with the old tsc and were ignored

server/tsconfig.json

error TS2341: Property 'enabled' is private and only accessible within class 'SearchService'.

microsoft/vscode

5 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.monaco.json

error TS2446: Property 'config' is protected and only accessible through an instance of class 'ClosingBracketKind'. This is an instance of class 'OpeningBracketKind'.
- src/vs/editor/common/languages/supports/languageBracketsConfiguration.ts#L145
- src/vs/editor/common/languages/supports/languageBracketsConfiguration.ts#L152

src/tsconfig.tsec.json

error TS2446: Property 'config' is protected and only accessible through an instance of class 'ClosingBracketKind'. This is an instance of class 'OpeningBracketKind'.
- src/vs/editor/common/languages/supports/languageBracketsConfiguration.ts#L145
- src/vs/editor/common/languages/supports/languageBracketsConfiguration.ts#L152

DanielRosenwasser · 2023-09-29T00:12:04Z

Oh my

jakebailey · 2023-09-29T02:19:08Z

So I guess a lot of people accidentally stumbled on this hole and used it to violate accessible rules?

Jack-Works · 2023-09-29T12:13:04Z

yeah, this has been repeatedly found as a "bug" but actually is a feature (#42360).

maybe the team should add some comment in the checker, or emit a Message (hint) in IDE that this is violating visibility so people won't repeatedly report/fix this.

jakebailey · 2023-09-29T15:08:38Z

Personally, I don't think this is a good hole to have. If someone wants to violate visibility rules, they can as any. I have never thought to try and skip past visibility via this["..."]. The list of breaks isn't that long.

rubiesonthesky · 2023-09-29T16:10:31Z

This is really nice way to access class properties in test while, for example, when testing angular components. as any will lose all other type checking and that is in most cases not wanted. The other way is to use ts-ignore but then again you are hiding a lot other mistakes. I understand that you would not want to have this type hole in production code but fixing it will make writing some tests much harder. (Easiest fix is to change component code where property will no longer be private, but that is not desirable in most cases).

I wish there was some legit way to side step private in test files without losing type information. :/

DanielRosenwasser · 2023-09-29T19:38:55Z

I don't think we can remove the accessibility checks without a broader discussion. If we want to reduce the scope to just super["..."] for instance property checks, that's fine, but we would need to bring this to a design meeting

weswigham · 2023-10-03T20:04:35Z

Personally, I don't think this is a good hole to have.

I don't think we can remove the accessibility checks without a broader discussion.

We could always put it behind a strictness option if we're worried about it being a break - it's pretty in-line with the existing indexed-access relaxing option, suppressImplicitAnyIndexErrors, though admittedly not implicit-any-related, so maybe we shouldn't bundle it into that option specifically.

sandersn · 2023-10-09T22:16:36Z

We could always put it behind a strictness option

If the option joins the --strict family, then we would need some additional way to disable it for just test files, since otherwise-strict code bases might still want to use it for tests. Actually, that would be nice whether or not it's part of the --strict.

weswigham · 2023-11-06T23:37:15Z

@DanielRosenwasser didn't we bring this up in a design meeting? Did we come to a conclusion on if we should merge this as-is or flag it as a strictness improvement?

…ix/55899

a-tarasyuk · 2024-10-06T14:55:04Z

@DanielRosenwasser @RyanCavanaugh @weswigham @sandersn This PR has been open for a while., should these changes be under the suppressImplicitAnyIndexErrors option, or should the current approach remain unchanged?

DanielRosenwasser · 2024-10-08T21:07:08Z

This didn't come up at a design meeting yet - we should discuss it.

That said, the affected test has a comment explaining the behavior:

    // Indexed access expressions have always permitted access to private and protected members.
    // For consistency we also permit such access in indexed access types.

So it probably makes more sense to have under a --strict flag if we're set on changing things. What the flag name is, I don't know.

a-tarasyuk · 2025-02-22T23:08:37Z

This didn't come up at a design meeting yet - we should discuss it.

@DanielRosenwasser thank you for your feedback. I’d appreciate it if you could add it to the design meeting queue when you get a chance.

fix(55899): check element access on super instance properties

53a4088

typescript-bot assigned sandersn Sep 28, 2023

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 28, 2023

DanielRosenwasser requested review from weswigham and RyanCavanaugh September 28, 2023 19:01

DanielRosenwasser approved these changes Sep 28, 2023

View reviewed changes

DanielRosenwasser self-requested a review September 29, 2023 00:12

a-tarasyuk added 2 commits August 18, 2024 23:21

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

7fc1c80

…ix/55899

update baseline

8c81038

jakebailey mentioned this pull request Feb 28, 2025

Restrict indexed accesses on nonpublic fields of concrete types the same way we do generic ones #61291

Open

a-tarasyuk closed this Mar 24, 2025

github-project-automation bot moved this from Waiting on reviewers to Done in PR Backlog Mar 24, 2025

sandersn removed this from PR Backlog Apr 22, 2025

fix(55899): Indexing/element access on super avoids instance property checks #55903

fix(55899): Indexing/element access on super avoids instance property checks #55903

Uh oh!

Conversation

a-tarasyuk commented Sep 28, 2023

Uh oh!

DanielRosenwasser commented Sep 28, 2023

Uh oh!

typescript-bot commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 28, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 28, 2023

Uh oh!

DanielRosenwasser commented Sep 29, 2023

Uh oh!

jakebailey commented Sep 29, 2023

Uh oh!

Jack-Works commented Sep 29, 2023

Uh oh!

jakebailey commented Sep 29, 2023

Uh oh!

rubiesonthesky commented Sep 29, 2023

Uh oh!

DanielRosenwasser commented Sep 29, 2023

Uh oh!

weswigham commented Oct 3, 2023

Uh oh!

sandersn commented Oct 9, 2023

Uh oh!

weswigham commented Nov 6, 2023

Uh oh!

a-tarasyuk commented Oct 6, 2024

Uh oh!

DanielRosenwasser commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

a-tarasyuk commented Feb 22, 2025

Uh oh!

Uh oh!

typescript-bot commented Sep 28, 2023 •

edited

Loading

typescript-bot commented Sep 28, 2023 •

edited

Loading

DanielRosenwasser commented Oct 8, 2024 •

edited

Loading