Update dprint-typescript to 0.88.1, reformat #55913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Sep 29, 2023
|
I could make the update job do that, yeah. It'd just have to also commit the new formatting, and I was not sure if that was desirable or not given there could be dprint bugs that come up. |
|
It could do auto update when no change is needed in code and create PR with update of dprint and code otherwise? |
|
Yeah, I'll see what I can do there. That should be possible. |
|
I think I'll be able to reuse the workflow code from my WIP cherry-pick pipeline replacement workflow (hopefully done soon, doing like 50 things at once) Both workflows are situations where we want to push to a specific branch and then send a PR if there isn't one yet. For now though, I'm just going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a formatting bug when using multi-line strings.