pass program update level to getExternalFiles in tsserver plugins so plugins can make decision about their cache based on that #56047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
sheetalkamat
commented
Oct 9, 2023
| /** Update the file name list from the disk */ | ||
| Partial, | ||
| /** Reload completely by re-reading contents of config file from disk and updating program */ | ||
| export enum ProgramUpdateLevel { |
There was a problem hiding this comment.
Just renamed this and exposed as Public API for use in getExternalFiles
sheetalkamat
commented
Oct 9, 2023
| @@ -1892,10 +1892,10 @@ export abstract class Project implements LanguageServiceHost, ModuleResolutionHo | |||
| } | |||
| // compute and return the difference | |||
| const lastReportedFileNames = this.lastReportedFileNames; | |||
| const externalFiles = this.getExternalFiles().map((f): protocol.FileWithProjectReferenceRedirectInfo => ({ | |||
| const externalFiles = this.externalFiles?.map((f): protocol.FileWithProjectReferenceRedirectInfo => ({ | |||
There was a problem hiding this comment.
this shouldnt have been querying things again from modules but should have been returning the current state in the first place. so just made that change
andrewbranch
approved these changes
Oct 9, 2023
Co-authored-by: Andrew Branch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we called getExternalFiles on every project update (and some) To get correct behaviour, plugin users had to either watch things by themselves or inefficient way of refreshing this every call or just dont handle the updtes well
This passes the program update level to getExternalFiles so plugin users can make decisions based on that.
Fixes #56044