Fixes use of combination of options sourceRoot and mapRoot with inlineSourceMap and inlineSources #5620
+335
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… --sourceRoot Note that --sourceRoot fails with crash
|
👍 |
sheetalkamat
added a commit
that referenced
this pull request
Nov 12, 2015
Fixes use of combination of options sourceRoot and mapRoot with inlineSourceMap and inlineSources
|
Quick question. Why is the combination of inlineSources and sourceRoot not allowed? Without being able to set sourceRoot, the source field will always contain relative paths. These paths are used in stack traces. So the the user will see "../../../../../angular2/src/core.ts", which can be confusing. |
|
|
|
The source file is not used, but the sources property is still used in track traces. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also handles : #5613