Fix(55658): Move to file and new file syntax errors with overload functions #56212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
src/services/refactors/moveToFile.ts
Outdated
| @@ -348,7 +348,7 @@ function getTargetFileImportsAndAddExportInOldFile( | |||
| if (hasSyntacticModifier(decl, ModifierFlags.Default)) { | |||
| oldFileDefault = name; | |||
| } | |||
| else { | |||
| else if (!oldFileNamedImports.includes (name.text)) { | |||
There was a problem hiding this comment.
Suggested change
| else if (!oldFileNamedImports.includes (name.text)) { | |
| else if (!oldFileNamedImports.includes(name.text)) { | |
RyanCavanaugh
requested changes
Oct 24, 2023
| @@ -176,7 +176,7 @@ function getNewFileImportsAndAddExportInOldFile( | |||
| if (hasSyntacticModifier(decl, ModifierFlags.Default)) { | |||
| oldFileDefault = name; | |||
| } | |||
| else { | |||
| else if (!oldFileNamedImports.includes (name.text)) { | |||
There was a problem hiding this comment.
Let's deduplicate this code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55658
Importing overload functions caused this issue. Fixed it by ensuring that a symbol's declaration for an overload function was being imported only once.