-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Path mapping module resolution #5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d2fd643
initial implementation of path mapping based module resolution
vladima 6bed1ba
merge with master
vladima 6844285
verbose module resolution
vladima cccdd44
merge with master
vladima 25cc97b
addressed PR feedback
vladima 62370a0
addressed PR feedback
vladima 0377e7a
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 4e3cba1
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima cc25f2c
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 0d0de5a
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima f18e203
fix merge issues
vladima 9a9b51f
merge with master
vladima 0130c23
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima bb9498f
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 2dbf621
merge with origin/master, add trace message with type of 'typings' fi…
vladima 6a63c0d
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima a81c875
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima c644fb3
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 57e7615
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 6b4bc43
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 5327868
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima c06be3a
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima a399208
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 39a50fa
merge with origin/master
vladima 635201c
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 73c94d0
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 3d4e220
merge with origin/master
vladima 39ad077
merge with origin/master
vladima 9d828e3
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima cb3e93f
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 2b2b150
Merge remote-tracking branch 'origin/master' into pathMappingModuleRe…
vladima 8a8ed0a
update implementation based on the results of design meeting
vladima adacad3
addressed PR feedback
vladima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,8 +74,6 @@ namespace ts { | |
GreaterThan = 1 | ||
} | ||
|
||
export interface StringSet extends Map<any> { } | ||
|
||
/** | ||
* Iterates through 'array' by index and performs the callback on each element of array until the callback | ||
* returns a truthy value, then returns that value. | ||
|
@@ -441,6 +439,17 @@ namespace ts { | |
}; | ||
} | ||
|
||
/* internal */ | ||
export function formatMessage(dummy: any, message: DiagnosticMessage): string { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need the first argument here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is necessary to skip |
||
let text = getLocaleSpecificMessage(message); | ||
|
||
if (arguments.length > 2) { | ||
text = formatStringFromArgs(text, arguments, 2); | ||
} | ||
|
||
return text; | ||
} | ||
|
||
export function createCompilerDiagnostic(message: DiagnosticMessage, ...args: any[]): Diagnostic; | ||
export function createCompilerDiagnostic(message: DiagnosticMessage): Diagnostic { | ||
let text = getLocaleSpecificMessage(message); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a line note