Set `impliedNodeFormat` in every module mode #57570

andrewbranch · 2024-02-28T00:14:40Z

This is a starting point for substantive changes, only up in this state to test perf and breaking changes.

andrewbranch · 2024-02-28T00:15:03Z

@typescript-bot perf test
@typescript-bot test top200

typescript-bot · 2024-02-28T00:15:07Z

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 74fc5a5. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-28T00:15:07Z

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at 74fc5a5. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-28T00:58:11Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,646k (± 0.01%)}	_{296,605k (± 0.00%)}	_{+959k (+ 0.32%)}	_296,591k	_296,626k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.28%)}	_{2.68s (± 0.61%)}	_{+0.02s (+ 0.81%)}	_2.67s	_2.71s	_{p=0.015 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 0.62%)}	_{+0.01s (+ 1.01%)}	_0.83s	_0.84s	_{p=0.038 n=6}
_{Check Time}	_{8.23s (± 0.33%)}	_{8.26s (± 0.25%)}	_~	_8.24s	_8.29s	_{p=0.060 n=6}
_{Emit Time}	_{7.11s (± 0.26%)}	_{7.12s (± 0.33%)}	_~	_7.09s	_7.15s	_{p=0.622 n=6}
_{Total Time}	_{18.82s (± 0.18%)}	_{18.90s (± 0.21%)}	_{+0.07s (+ 0.40%)}	_18.86s	_18.95s	_{p=0.008 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{195,432k (± 1.54%)}	_{192,587k (± 1.23%)}	_~	_191,607k	_197,414k	_{p=0.689 n=6}
_{Parse Time}	_{1.36s (± 1.14%)}	_{1.37s (± 1.49%)}	_~	_1.34s	_1.40s	_{p=0.366 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.35s (± 0.09%)}	_{9.34s (± 0.22%)}	_~	_9.31s	_9.37s	_{p=0.797 n=6}
_{Emit Time}	_{2.62s (± 0.75%)}	_{2.63s (± 0.52%)}	_~	_2.60s	_2.64s	_{p=0.357 n=6}
_{Total Time}	_{14.04s (± 0.31%)}	_{14.06s (± 0.18%)}	_~	_14.04s	_14.11s	_{p=0.089 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,425k (± 0.01%)}	_{348,494k (± 0.00%)}	_{+1,069k (+ 0.31%)}	_348,479k	_348,516k	_{p=0.005 n=6}
_{Parse Time}	_{2.48s (± 0.59%)}	_{2.54s (± 0.25%)}	_{+0.06s (+ 2.49%)}	_2.53s	_2.55s	_{p=0.004 n=6}
_{Bind Time}	_{0.92s (± 0.59%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=0.071 n=6}
_{Check Time}	_{6.94s (± 0.40%)}	_{6.98s (± 0.36%)}	_{+0.04s (+ 0.53%)}	_6.94s	_7.01s	_{p=0.044 n=6}
_{Emit Time}	_{4.06s (± 0.24%)}	_{4.07s (± 0.22%)}	_~	_4.06s	_4.08s	_{p=0.142 n=6}
_{Total Time}	_{14.41s (± 0.17%)}	_{14.52s (± 0.18%)}	_{+0.11s (+ 0.76%)}	_14.48s	_14.54s	_{p=0.005 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,859k (± 0.01%)}	_{303,113k (± 0.00%)}	_{+254k (+ 0.08%)}	_303,099k	_303,137k	_{p=0.005 n=6}
_{Parse Time}	_{2.02s (± 0.68%)}	_{2.03s (± 0.41%)}	_{+0.02s (+ 0.91%)}	_2.03s	_2.05s	_{p=0.033 n=6}
_{Bind Time}	_{1.00s (± 1.22%)}	_{1.00s (± 0.41%)}	_~	_0.99s	_1.00s	_{p=0.389 n=6}
_{Check Time}	_{6.36s (± 0.40%)}	_{6.35s (± 0.26%)}	_~	_6.33s	_6.38s	_{p=0.683 n=6}
_{Emit Time}	_{3.60s (± 0.29%)}	_{3.60s (± 0.52%)}	_~	_3.58s	_3.62s	_{p=0.802 n=6}
_{Total Time}	_{12.98s (± 0.27%)}	_{12.98s (± 0.23%)}	_~	_12.94s	_13.02s	_{p=0.685 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,250k (± 0.00%)}	_{512,333k (± 0.01%)}	_{+1,082k (+ 0.21%)}	_512,275k	_512,370k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.52%)}	_{2.70s (± 0.45%)}	_{+0.04s (+ 1.57%)}	_2.68s	_2.71s	_{p=0.005 n=6}
_{Bind Time}	_{1.00s (± 1.05%)}	_{0.99s (± 1.22%)}	_~	_0.98s	_1.01s	_{p=0.868 n=6}
_{Check Time}	_{17.28s (± 0.39%)}	_{17.29s (± 0.67%)}	_~	_17.16s	_17.47s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.92s (± 0.31%)}	_{20.98s (± 0.58%)}	_~	_20.86s	_21.19s	_{p=0.468 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,295,429k (± 0.00%)}	_{2,307,742k (± 0.00%)}	_{+12,313k (+ 0.54%)}	_2,307,627k	_2,307,871k	_{p=0.005 n=6}
_{Parse Time}	_{12.00s (± 0.85%)}	_{12.36s (± 0.74%)}	_{+0.36s (+ 2.99%)}	_12.28s	_12.53s	_{p=0.005 n=6}
_{Bind Time}	_{2.65s (± 0.31%)}	_{2.65s (± 0.48%)}	_~	_2.63s	_2.66s	_{p=0.796 n=6}
_{Check Time}	_{102.23s (± 0.43%)}	_{103.31s (± 1.20%)}	_~	_101.27s	_105.07s	_{p=0.066 n=6}
_{Emit Time}	_{0.32s (± 1.27%)}	_{0.33s (± 2.50%)}	_~	_0.32s	_0.34s	_{p=0.248 n=6}
_{Total Time}	_{117.20s (± 0.35%)}	_{118.65s (± 1.00%)}	_{+1.45s (+ 1.23%)}	_116.76s	_120.41s	_{p=0.045 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,405,654k (± 0.03%)}	_{2,406,467k (± 0.02%)}	_~	_2,405,689k	_2,407,008k	_{p=0.066 n=6}
_{Parse Time}	_{5.16s (± 0.89%)}	_{5.13s (± 1.03%)}	_~	_5.05s	_5.20s	_{p=0.335 n=6}
_{Bind Time}	_{1.88s (± 0.55%)}	_{1.90s (± 0.72%)}	_~	_1.88s	_1.92s	_{p=0.098 n=6}
_{Check Time}	_{33.67s (± 0.26%)}	_{33.65s (± 0.50%)}	_~	_33.49s	_33.95s	_{p=0.630 n=6}
_{Emit Time}	_{2.73s (± 1.17%)}	_{2.70s (± 0.86%)}	_~	_2.66s	_2.73s	_{p=0.126 n=6}
_{Total Time}	_{43.47s (± 0.32%)}	_{43.39s (± 0.39%)}	_~	_43.19s	_43.69s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,709k (± 0.01%)}	_{418,899k (± 0.01%)}	_{+190k (+ 0.05%)}	_418,871k	_418,956k	_{p=0.005 n=6}
_{Parse Time}	_{2.83s (± 1.29%)}	_{2.82s (± 1.20%)}	_~	_2.79s	_2.88s	_{p=0.746 n=6}
_{Bind Time}	_{1.08s (± 0.48%)}	_{1.08s (± 0.38%)}	_~	_1.07s	_1.08s	_{p=0.595 n=6}
_{Check Time}	_{15.23s (± 0.34%)}	_{15.22s (± 0.22%)}	_~	_15.19s	_15.27s	_{p=0.746 n=6}
_{Emit Time}	_{1.16s (± 0.89%)}	_{1.16s (± 1.60%)}	_~	_1.14s	_1.19s	_{p=0.677 n=6}
_{Total Time}	_{20.30s (± 0.29%)}	_{20.29s (± 0.16%)}	_~	_20.24s	_20.34s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,850,581k (± 0.00%)}	_{2,855,595k (± 0.00%)}	_{+5,014k (+ 0.18%)}	_2,855,568k	_2,855,647k	_{p=0.005 n=6}
_{Parse Time}	_{10.75s (± 0.24%)}	_{11.11s (± 0.22%)}	_{+0.36s (+ 3.33%)}	_11.08s	_11.13s	_{p=0.005 n=6}
_{Bind Time}	_{3.43s (± 0.50%)}	_{3.43s (± 0.18%)}	_~	_3.42s	_3.44s	_{p=1.000 n=6}
_{Check Time}	_{60.71s (± 0.39%)}	_{60.60s (± 0.38%)}	_~	_60.29s	_60.82s	_{p=0.471 n=6}
_{Emit Time}	_{16.27s (± 0.53%)}	_{16.31s (± 0.55%)}	_~	_16.18s	_16.43s	_{p=0.470 n=6}
_{Total Time}	_{91.16s (± 0.29%)}	_{91.44s (± 0.26%)}	_{+0.28s (+ 0.31%)}	_91.19s	_91.75s	_{p=0.045 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{397,031k (± 0.01%)}	_{397,597k (± 0.01%)}	_{+566k (+ 0.14%)}	_397,529k	_397,643k	_{p=0.005 n=6}
_{Parse Time}	_{3.16s (± 0.54%)}	_{3.21s (± 0.51%)}	_{+0.06s (+ 1.74%)}	_3.19s	_3.23s	_{p=0.005 n=6}
_{Bind Time}	_{1.39s (± 0.87%)}	_{1.40s (± 0.97%)}	_~	_1.38s	_1.42s	_{p=0.215 n=6}
_{Check Time}	_{14.04s (± 0.39%)}	_{14.08s (± 0.40%)}	_~	_14.01s	_14.15s	_{p=0.227 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.59s (± 0.35%)}	_{18.70s (± 0.39%)}	_{+0.11s (+ 0.57%)}	_18.61s	_18.78s	_{p=0.044 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,369k (± 0.01%)}	_{514,055k (± 0.02%)}	_{+686k (+ 0.13%)}	_513,930k	_514,179k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 0.31%)}	_{3.33s (± 0.19%)}	_{+0.05s (+ 1.63%)}	_3.32s	_3.34s	_{p=0.004 n=6}
_{Bind Time}	_{1.54s (± 0.33%)}	_{1.55s (± 0.33%)}	_{+0.01s (+ 0.65%)}	_1.55s	_1.56s	_{p=0.018 n=6}
_{Check Time}	_{2.87s (± 0.70%)}	_{2.87s (± 0.70%)}	_~	_2.84s	_2.90s	_{p=1.000 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.77s (± 0.32%)}	_{7.84s (± 0.21%)}	_{+0.07s (+ 0.88%)}	_7.83s	_7.87s	_{p=0.004 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,346ms (± 0.68%)}	_{2,366ms (± 0.91%)}	_~	_2,340ms	_2,391ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{5,572ms (± 1.54%)}	_{5,516ms (± 1.10%)}	_~	_5,480ms	_5,637ms	_{p=0.575 n=6}
_{Req 3 - references}	_{323ms (± 0.32%)}	_{330ms (± 1.04%)}	_{+6ms (+ 1.96%)}	_324ms	_333ms	_{p=0.010 n=6}
_{Req 4 - navto}	_{274ms (± 0.92%)}	_{274ms (± 0.44%)}	_~	_272ms	_275ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 8.21%)}	_{81ms (± 5.19%)}	_~	_78ms	_89ms	_{p=0.072 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,478ms (± 0.83%)}	_{2,502ms (± 0.57%)}	_~	_2,475ms	_2,514ms	_{p=0.054 n=6}
_{Req 2 - geterr}	_{4,136ms (± 0.21%)}	_{4,173ms (± 1.67%)}	_~	_4,124ms	_4,276ms	_{p=1.000 n=6}
_{Req 3 - references}	_{335ms (± 0.90%)}	_{336ms (± 1.39%)}	_~	_330ms	_342ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{286ms (± 0.19%)}	_{288ms (± 0.34%)}	_{+2ms (+ 0.82%)}	_287ms	_289ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 0.84%)}	_{87ms (± 4.73%)}	_~	_79ms	_90ms	_{p=0.437 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,613ms (± 0.55%)}	_{2,645ms (± 0.44%)}	_{+32ms (+ 1.23%)}	_2,628ms	_2,656ms	_{p=0.010 n=6}
_{Req 2 - geterr}	_{1,739ms (± 2.77%)}	_{1,730ms (± 2.45%)}	_~	_1,675ms	_1,795ms	_{p=0.873 n=6}
_{Req 3 - references}	_{114ms (± 8.75%)}	_{106ms (± 1.03%)}	_{🟩-8ms (- 6.74%)}	_105ms	_108ms	_{p=0.022 n=6}
_{Req 4 - navto}	_{371ms (± 0.23%)}	_{370ms (± 0.24%)}	_~	_369ms	_371ms	_{p=0.437 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{310ms (± 1.54%)}	_{322ms (± 1.78%)}	_{+12ms (+ 3.82%)}	_314ms	_327ms	_{p=0.014 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.74ms (± 0.21%)}	_{153.60ms (± 0.18%)}	_{-0.14ms (- 0.09%)}	_152.50ms	_156.01ms	_{p=0.001 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.70ms (± 0.21%)}	_{229.52ms (± 0.16%)}	_{-0.19ms (- 0.08%)}	_228.07ms	_233.64ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.19ms (± 0.19%)}	_{231.29ms (± 0.21%)}	_{+0.10ms (+ 0.04%)}	_229.53ms	_241.96ms	_{p=0.030 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.11ms (± 0.17%)}	_{231.11ms (± 0.20%)}	_~	_229.51ms	_237.85ms	_{p=0.278 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-02-28T01:33:10Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/57570/merge:

Everything looks good!

andrewbranch · 2024-02-28T22:22:44Z

@typescript-bot perf test

typescript-bot · 2024-02-28T22:22:46Z

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at ab5d376. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-28T23:10:21Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,530k (± 0.01%)}	_{296,765k (± 0.00%)}	_{+1,235k (+ 0.42%)}	_296,753k	_296,786k	_{p=0.005 n=6}
_{Parse Time}	_{2.67s (± 0.24%)}	_{2.70s (± 0.56%)}	_{+0.03s (+ 1.25%)}	_2.69s	_2.73s	_{p=0.004 n=6}
_{Bind Time}	_{0.83s (± 1.32%)}	_{0.84s (± 0.62%)}	_~	_0.83s	_0.84s	_{p=0.149 n=6}
_{Check Time}	_{8.26s (± 0.30%)}	_{8.24s (± 0.21%)}	_~	_8.21s	_8.26s	_{p=0.618 n=6}
_{Emit Time}	_{7.09s (± 0.22%)}	_{7.13s (± 0.41%)}	_{+0.04s (+ 0.52%)}	_7.08s	_7.16s	_{p=0.043 n=6}
_{Total Time}	_{18.84s (± 0.14%)}	_{18.91s (± 0.21%)}	_{+0.07s (+ 0.37%)}	_18.86s	_18.98s	_{p=0.008 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,191k (± 1.00%)}	_{192,669k (± 0.94%)}	_~	_191,474k	_195,024k	_{p=0.575 n=6}
_{Parse Time}	_{1.36s (± 0.86%)}	_{1.36s (± 0.55%)}	_~	_1.35s	_1.37s	_{p=0.796 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.33s (± 0.17%)}	_{9.36s (± 0.30%)}	_~	_9.33s	_9.40s	_{p=0.075 n=6}
_{Emit Time}	_{2.61s (± 0.34%)}	_{2.61s (± 0.34%)}	_~	_2.60s	_2.62s	_{p=1.000 n=6}
_{Total Time}	_{14.02s (± 0.18%)}	_{14.05s (± 0.19%)}	_~	_14.03s	_14.10s	_{p=0.063 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,349k (± 0.01%)}	_{348,427k (± 0.01%)}	_{+1,078k (+ 0.31%)}	_348,403k	_348,455k	_{p=0.005 n=6}
_{Parse Time}	_{2.46s (± 1.37%)}	_{2.54s (± 0.69%)}	_{+0.08s (+ 3.32%)}	_2.52s	_2.57s	_{p=0.005 n=6}
_{Bind Time}	_{0.93s (± 1.18%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=0.476 n=6}
_{Check Time}	_{6.95s (± 0.17%)}	_{6.96s (± 0.39%)}	_~	_6.93s	_7.00s	_{p=0.372 n=6}
_{Emit Time}	_{4.08s (± 0.39%)}	_{4.09s (± 0.18%)}	_~	_4.08s	_4.10s	_{p=0.136 n=6}
_{Total Time}	_{14.42s (± 0.07%)}	_{14.52s (± 0.28%)}	_{+0.10s (+ 0.71%)}	_14.47s	_14.58s	_{p=0.004 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,774k (± 0.01%)}	_{303,041k (± 0.00%)}	_{+267k (+ 0.09%)}	_303,031k	_303,049k	_{p=0.005 n=6}
_{Parse Time}	_{2.02s (± 0.75%)}	_{2.03s (± 0.51%)}	_~	_2.01s	_2.04s	_{p=0.241 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.114 n=6}
_{Check Time}	_{6.36s (± 0.55%)}	_{6.36s (± 0.40%)}	_~	_6.33s	_6.39s	_{p=1.000 n=6}
_{Emit Time}	_{3.63s (± 0.48%)}	_{3.60s (± 0.67%)}	_~	_3.57s	_3.64s	_{p=0.121 n=6}
_{Total Time}	_{13.00s (± 0.30%)}	_{12.99s (± 0.26%)}	_~	_12.94s	_13.04s	_{p=0.747 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,190k (± 0.00%)}	_{512,354k (± 0.01%)}	_{+1,164k (+ 0.23%)}	_512,299k	_512,384k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.51%)}	_{2.70s (± 0.49%)}	_{+0.05s (+ 1.82%)}	_2.68s	_2.71s	_{p=0.004 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{1.00s (± 1.03%)}	_~	_0.99s	_1.02s	_{p=0.063 n=6}
_{Check Time}	_{17.27s (± 0.48%)}	_{17.31s (± 0.18%)}	_~	_17.25s	_17.34s	_{p=0.574 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.92s (± 0.40%)}	_{21.02s (± 0.13%)}	_~	_20.97s	_21.05s	_{p=0.053 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,295,315k (± 0.00%)}	_{2,307,895k (± 0.00%)}	_{+12,580k (+ 0.55%)}	_2,307,851k	_2,308,016k	_{p=0.005 n=6}
_{Parse Time}	_{11.94s (± 0.73%)}	_{12.19s (± 0.69%)}	_{+0.24s (+ 2.05%)}	_12.09s	_12.28s	_{p=0.005 n=6}
_{Bind Time}	_{2.65s (± 0.52%)}	_{2.64s (± 0.39%)}	_~	_2.63s	_2.66s	_{p=0.737 n=6}
_{Check Time}	_{101.96s (± 1.26%)}	_{101.98s (± 0.74%)}	_~	_101.00s	_103.00s	_{p=0.575 n=6}
_{Emit Time}	_{0.32s (± 1.27%)}	_{0.33s (± 2.45%)}	_{+0.01s (+ 3.63%)}	_0.32s	_0.34s	_{p=0.024 n=6}
_{Total Time}	_{116.87s (± 1.08%)}	_{117.14s (± 0.73%)}	_~	_116.06s	_118.26s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,611k (± 0.03%)}	_{2,396,726k (± 0.02%)}	_{+2,116k (+ 0.09%)}	_2,396,417k	_2,397,415k	_{p=0.005 n=6}
_{Parse Time}	_{5.05s (± 1.05%)}	_{5.08s (± 0.92%)}	_~	_5.00s	_5.12s	_{p=0.230 n=6}
_{Bind Time}	_{1.89s (± 1.28%)}	_{1.90s (± 0.73%)}	_~	_1.88s	_1.91s	_{p=1.000 n=6}
_{Check Time}	_{33.56s (± 0.26%)}	_{33.48s (± 0.43%)}	_~	_33.34s	_33.72s	_{p=0.378 n=6}
_{Emit Time}	_{2.65s (± 1.54%)}	_{2.72s (± 1.06%)}	_{+0.06s (+ 2.39%)}	_2.67s	_2.75s	_{p=0.025 n=6}
_{Total Time}	_{43.17s (± 0.26%)}	_{43.19s (± 0.25%)}	_~	_43.08s	_43.33s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,614k (± 0.01%)}	_{414,839k (± 0.01%)}	_{+225k (+ 0.05%)}	_414,800k	_414,866k	_{p=0.005 n=6}
_{Parse Time}	_{2.80s (± 0.98%)}	_{2.81s (± 0.89%)}	_~	_2.76s	_2.83s	_{p=0.746 n=6}
_{Bind Time}	_{1.07s (± 0.70%)}	_{1.07s (± 0.59%)}	_~	_1.06s	_1.08s	_{p=0.718 n=6}
_{Check Time}	_{15.14s (± 0.13%)}	_{15.08s (± 0.21%)}	_{-0.06s (- 0.42%)}	_15.03s	_15.11s	_{p=0.006 n=6}
_{Emit Time}	_{1.10s (± 0.95%)}	_{1.11s (± 1.49%)}	_~	_1.09s	_1.13s	_{p=0.869 n=6}
_{Total Time}	_{20.11s (± 0.14%)}	_{20.06s (± 0.28%)}	_~	_19.98s	_20.14s	_{p=0.123 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,851,462k (± 0.00%)}	_{2,857,071k (± 0.00%)}	_{+5,609k (+ 0.20%)}	_2,857,049k	_2,857,114k	_{p=0.005 n=6}
_{Parse Time}	_{10.74s (± 0.46%)}	_{11.00s (± 0.18%)}	_{+0.26s (+ 2.42%)}	_10.98s	_11.03s	_{p=0.005 n=6}
_{Bind Time}	_{3.43s (± 0.40%)}	_{3.44s (± 0.36%)}	_~	_3.43s	_3.46s	_{p=0.183 n=6}
_{Check Time}	_{60.82s (± 0.87%)}	_{60.62s (± 0.24%)}	_~	_60.35s	_60.76s	_{p=0.298 n=6}
_{Emit Time}	_{16.22s (± 0.50%)}	_{16.19s (± 0.35%)}	_~	_16.12s	_16.26s	_{p=0.377 n=6}
_{Total Time}	_{91.22s (± 0.57%)}	_{91.26s (± 0.20%)}	_~	_90.93s	_91.44s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{397,009k (± 0.01%)}	_{397,626k (± 0.01%)}	_{+617k (+ 0.16%)}	_397,535k	_397,682k	_{p=0.005 n=6}
_{Parse Time}	_{3.16s (± 0.49%)}	_{3.19s (± 0.56%)}	_{+0.03s (+ 0.95%)}	_3.16s	_3.21s	_{p=0.022 n=6}
_{Bind Time}	_{1.39s (± 1.15%)}	_{1.39s (± 0.74%)}	_~	_1.38s	_1.41s	_{p=0.618 n=6}
_{Check Time}	_{14.13s (± 0.44%)}	_{14.07s (± 0.22%)}	_~	_14.02s	_14.10s	_{p=0.145 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.67s (± 0.34%)}	_{18.66s (± 0.22%)}	_~	_18.60s	_18.72s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,123k (± 0.01%)}	_{513,927k (± 0.01%)}	_{+804k (+ 0.16%)}	_513,817k	_514,015k	_{p=0.005 n=6}
_{Parse Time}	_{3.27s (± 0.12%)}	_{3.33s (± 0.32%)}	_{+0.06s (+ 1.73%)}	_3.31s	_3.34s	_{p=0.004 n=6}
_{Bind Time}	_{1.54s (± 0.53%)}	_{1.55s (± 0.26%)}	_{+0.01s (+ 0.54%)}	_1.55s	_1.56s	_{p=0.038 n=6}
_{Check Time}	_{2.87s (± 0.46%)}	_{2.85s (± 0.43%)}	_~	_2.84s	_2.87s	_{p=0.086 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.77s (± 0.24%)}	_{7.82s (± 0.11%)}	_{+0.05s (+ 0.64%)}	_7.81s	_7.83s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,353ms (± 1.00%)}	_{2,353ms (± 0.83%)}	_~	_2,331ms	_2,377ms	_{p=0.872 n=6}
_{Req 2 - geterr}	_{5,525ms (± 1.27%)}	_{5,539ms (± 1.47%)}	_~	_5,472ms	_5,646ms	_{p=0.471 n=6}
_{Req 3 - references}	_{327ms (± 1.54%)}	_{326ms (± 1.46%)}	_~	_322ms	_332ms	_{p=0.870 n=6}
_{Req 4 - navto}	_{276ms (± 0.98%)}	_{274ms (± 1.00%)}	_~	_271ms	_278ms	_{p=0.333 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 8.11%)}	_{85ms (± 7.43%)}	_~	_79ms	_93ms	_{p=0.798 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,477ms (± 0.63%)}	_{2,488ms (± 0.66%)}	_~	_2,463ms	_2,509ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{4,212ms (± 1.86%)}	_{4,178ms (± 1.91%)}	_~	_4,122ms	_4,294ms	_{p=0.229 n=6}
_{Req 3 - references}	_{333ms (± 0.46%)}	_{332ms (± 0.83%)}	_~	_329ms	_337ms	_{p=0.360 n=6}
_{Req 4 - navto}	_{287ms (± 1.26%)}	_{286ms (± 0.48%)}	_~	_284ms	_287ms	_{p=0.745 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 7.69%)}	_{85ms (± 7.09%)}	_~	_76ms	_90ms	_{p=0.677 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,614ms (± 0.30%)}	_{2,630ms (± 0.35%)}	_{+15ms (+ 0.59%)}	_2,617ms	_2,639ms	_{p=0.020 n=6}
_{Req 2 - geterr}	_{1,731ms (± 0.87%)}	_{1,728ms (± 2.27%)}	_~	_1,673ms	_1,769ms	_{p=0.936 n=6}
_{Req 3 - references}	_{117ms (± 9.83%)}	_{116ms (± 9.45%)}	_~	_105ms	_127ms	_{p=0.465 n=6}
_{Req 4 - navto}	_{371ms (± 0.31%)}	_{377ms (± 0.64%)}	_{+6ms (+ 1.48%)}	_374ms	_381ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{309ms (± 1.10%)}	_{319ms (± 2.51%)}	_{+10ms (+ 3.29%)}	_308ms	_326ms	_{p=0.036 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.10ms (± 0.15%)}	_{153.19ms (± 0.15%)}	_{+0.09ms (+ 0.06%)}	_152.27ms	_156.86ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.38ms (± 0.17%)}	_{228.99ms (± 0.16%)}	_{-0.39ms (- 0.17%)}	_227.83ms	_235.45ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.65ms (± 0.15%)}	_{230.87ms (± 0.17%)}	_{+0.21ms (+ 0.09%)}	_228.89ms	_238.24ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.84ms (± 0.17%)}	_{231.94ms (± 0.14%)}	_{+0.10ms (+ 0.04%)}	_230.50ms	_234.54ms	_{p=0.001 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

…ncing

typescript-bot · 2024-03-05T19:27:13Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

andrewbranch · 2024-03-05T19:27:17Z

@typescript-bot test top200

typescript-bot · 2024-03-05T19:27:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started

typescript-bot · 2024-03-05T20:44:30Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/57570/merge:

Something interesting changed - please have a look.

Details

abi/screenshot-to-code

frontend/tsconfig.json

error TS2349: This expression is not callable.
- frontend/src/App.tsx#L103
error TS2339: Property 'error' does not exist on type 'typeof import("/mnt/ts_downloads/screenshot-to-code/frontend/node_modules/react-hot-toast/dist/index")'.
error TS2339: Property 'success' does not exist on type 'typeof import("/mnt/ts_downloads/screenshot-to-code/frontend/node_modules/react-hot-toast/dist/index")'.
- frontend/src/components/CodeTab.tsx#L18
- frontend/src/generateCode.ts#L47
error TS2604: JSX element type 'CaretSortIcon' does not have any construct or call signatures.
- frontend/src/components/history/HistoryDisplay.tsx#L69
- frontend/src/components/ui/select.tsx#L32
error TS2786: 'CaretSortIcon' cannot be used as a JSX component.
- frontend/src/components/history/HistoryDisplay.tsx#L69
- frontend/src/components/ui/select.tsx#L32
error TS2604: JSX element type 'ChevronDownIcon' does not have any construct or call signatures.
- frontend/src/components/ui/accordion.tsx#L35
- frontend/src/components/ui/select.tsx#L67
error TS2786: 'ChevronDownIcon' cannot be used as a JSX component.
- frontend/src/components/ui/accordion.tsx#L35
- frontend/src/components/ui/select.tsx#L67
error TS2604: JSX element type 'CheckIcon' does not have any construct or call signatures.
- frontend/src/components/ui/checkbox.tsx#L22
- frontend/src/components/ui/select.tsx#L131
error TS2786: 'CheckIcon' cannot be used as a JSX component.
- frontend/src/components/ui/checkbox.tsx#L22
- frontend/src/components/ui/select.tsx#L131
error TS2604: JSX element type 'Cross2Icon' does not have any construct or call signatures.
- frontend/src/components/ui/dialog.tsx#L46
error TS2786: 'Cross2Icon' cannot be used as a JSX component.
- frontend/src/components/ui/dialog.tsx#L46
error TS2604: JSX element type 'ChevronUpIcon' does not have any construct or call signatures.
- frontend/src/components/ui/select.tsx#L50
error TS2786: 'ChevronUpIcon' cannot be used as a JSX component.
- frontend/src/components/ui/select.tsx#L50

alibaba/ice

52 of 73 projects failed to build with the old tsc and were ignored

packages/create-ice/tsconfig.json

error TS2349: This expression is not callable.
- packages/create-ice/src/create.ts#L23

packages/plugin-css-assets-local/tsconfig.json

error TS2339: Property 'info' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/consola/types/consola")'.
- packages/plugin-css-assets-local/src/index.ts#L39

packages/plugin-i18n/tsconfig.json

error TS2709: Cannot use namespace 'Cookies' as a type.
- packages/plugin-i18n/src/utils/getLocaleFromCookie.ts#L9
error TS2351: This expression is not constructable.
- packages/plugin-i18n/src/utils/getLocaleFromCookie.ts#L9
- packages/plugin-i18n/src/utils/setLocaleToCookie.ts#L8

packages/plugin-icestark/tsconfig.json

error TS2604: JSX element type 'AppRouter' does not have any construct or call signatures.
- packages/plugin-icestark/src/runtime/framework.tsx#L49
error TS2604: JSX element type 'AppRoute' does not have any construct or call signatures.
- packages/plugin-icestark/src/runtime/framework.tsx#L57
- packages/plugin-icestark/src/runtime/framework.tsx#L63

packages/plugin-pha/tsconfig.json

error TS2339: Property 'log' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/consola/types/consola")'.
- packages/plugin-pha/src/index.ts#L159
error TS2339: Property 'error' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/consola/types/consola")'.
- packages/plugin-pha/src/manifestHelpers.ts#L288

packages/plugin-rax-compat/tsconfig.json

error TS2349: This expression is not callable.
- packages/plugin-rax-compat/src/lib/transform-styles.ts#L145

packages/plugin-request/tsconfig.json

error TS2349: This expression is not callable.
- packages/plugin-request/src/hooks.ts#L27
error TS2339: Property 'create' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/axios/index")'.
- packages/plugin-request/src/request.ts#L8
- packages/plugin-request/src/request.ts#L20
error TS2339: Property 'CancelToken' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/axios/index")'.
- packages/plugin-request/src/request.ts#L121
error TS2339: Property 'isCancel' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/axios/index")'.
- packages/plugin-request/src/request.ts#L122

packages/plugin-unocss/tsconfig.json

error TS2349: This expression is not callable.
- packages/plugin-unocss/src/index.ts#L31
- packages/plugin-unocss/src/index.ts#L37

packages/webpack-modify/tsconfig.json

error TS2339: Property 'warn' does not exist on type 'typeof import("/mnt/ts_downloads/ice/node_modules/.pnpm/[email protected]/node_modules/consola/types/consola")'.
- packages/webpack-modify/src/index.ts#L17

angular/angular-cli

4 of 22 projects failed to build with the old tsc and were ignored

tests/legacy-cli/e2e/assets/17-ssr-project-webpack/tsconfig.json

error TS2349: This expression is not callable.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L12
error TS7006: Parameter 'req' implicitly has an 'any' type.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L31
error TS7006: Parameter 'res' implicitly has an 'any' type.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L31
error TS7006: Parameter 'next' implicitly has an 'any' type.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L31
error TS2322: Type 'typeof import("/mnt/ts_downloads/angular-cli/tests/legacy-cli/e2e/assets/17-ssr-project-webpack/src/main.server")' is not assignable to type 'Type<{}> | (() => Promise<ApplicationRef>) | undefined'.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L36

tests/legacy-cli/e2e/assets/17-ssr-project-webpack/tsconfig.server.json

error TS2349: This expression is not callable.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L12
error TS7006: Parameter 'req' implicitly has an 'any' type.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L31
error TS7006: Parameter 'res' implicitly has an 'any' type.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L31
error TS7006: Parameter 'next' implicitly has an 'any' type.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L31
error TS2322: Type 'typeof import("/mnt/ts_downloads/angular-cli/tests/legacy-cli/e2e/assets/17-ssr-project-webpack/src/main.server")' is not assignable to type 'Type<{}> | (() => Promise<ApplicationRef>) | undefined'.
- tests/legacy-cli/e2e/assets/17-ssr-project-webpack/server.ts#L36

apache/superset

31 of 34 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

error TS2349: This expression is not callable.
error TS2604: JSX element type 'BlurredSection' does not have any construct or call signatures.
error TS2604: JSX element type 'SectionHeader' does not have any construct or call signatures.
error TS2604: JSX element type 'List' does not have any construct or call signatures.
- docs/src/pages/community.tsx#L197
error TS2339: Property 'Item' does not exist on type 'typeof import("/mnt/ts_downloads/superset/docs/node_modules/antd/lib/list/index")'.
error TS2604: JSX element type 'Carousel' does not have any construct or call signatures.
- docs/src/pages/index.tsx#L624

superset-embedded-sdk/tsconfig.json

error TS2349: This expression is not callable.
- superset-embedded-sdk/src/guestTokenRefresh.ts#L27

jakebailey · 2024-03-05T21:12:20Z

The pipeline actually failed to push due to the text being too long; will try and fix that, but it was about to send a looot of comments: https://typescript.visualstudio.com/TypeScript/_build/results?buildId=160202&view=logs&j=15ac8a4d-b341-5815-5352-14d7ae9c5a86&t=b4a5e2cd-8727-5d20-e3d3-86822d3c46a6

andrewbranch · 2024-03-06T18:55:31Z

@typescript-bot test top100

typescript-bot · 2024-03-06T18:55:34Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top100`	✅ Started	👀 Results

typescript-bot · 2024-03-06T19:36:37Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/57570/merge:

Something interesting changed - please have a look.

Details

microsoft/playwright

5 of 15 projects failed to build with the old tsc and were ignored

packages/html-reporter/tsconfig.json

error TS1192: Module '"/mnt/ts_downloads/playwright/node_modules/@zip.js/zip.js/index"' has no default export.
- packages/html-reporter/src/index.tsx#L18

andrewbranch · 2024-03-18T22:59:40Z

src/testRunner/unittests/tsc/projectReferences.ts

+                    import referencedSource from "../../lib/src/a"; // Error
+                    import referencedDeclaration from "../../lib/dist/a"; // Error


@sheetalkamat do you think it’s worth it to fix this? These two default imports would ideally error, because we could know by using the referenced project settings that the emit was ESM. We currently don’t error because we assume that a declaration file that says export declare const a = 0 could represent a CJS file. I’m not sure if it should be out of scope for this PR to start using referenced project settings to get more accurate information during type checking like this.

andrewbranch · 2024-03-18T23:22:37Z

@typescript-bot test top200

typescript-bot · 2024-03-18T23:22:40Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	👀 Results

typescript-bot · 2024-03-19T00:25:31Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/57570/merge:

Something interesting changed - please have a look.

Details

mattermost/mattermost

1 of 4 projects failed to build with the old tsc and were ignored

webapp/channels/tsconfig.json

error TS2339: Property 'highlight' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/mattermost/webapp/node_modules/highlight.js/lib/core")'.
- webapp/channels/src/utils/syntax_highlighting.tsx#L26 in webapp/channels/tsconfig.json
error TS2339: Property 'registerLanguage' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/mattermost/webapp/node_modules/highlight.js/lib/core")'.

microsoft/playwright

4 of 15 projects failed to build with the old tsc and were ignored

packages/html-reporter/tsconfig.json

error TS1192: Module '"/mnt/ts_downloads/_/m/playwright/node_modules/@zip.js/zip.js/index"' has no default export.
- packages/html-reporter/src/index.tsx#L18

nextauthjs/next-auth

20 of 41 projects failed to build with the old tsc and were ignored

packages/adapter-surrealdb/tsconfig.json

error TS2709: Cannot use namespace 'Surreal' as a type.
- packages/adapter-surrealdb/src/index.ts#L206
error TS4078: Parameter 'client' of exported function has or is using private name 'Surreal'.
- packages/adapter-surrealdb/src/index.ts#L206
error TS2347: Untyped function calls may not accept type arguments.

ueberdosis/tiptap

3 of 8 projects failed to build with the old tsc and were ignored

tests/cypress/tsconfig.json

error TS2339: Property 'getLanguage' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/tiptap/node_modules/highlight.js/lib/core")'.
- packages/extension-code-block-lowlight/src/lowlight-plugin.ts#L31

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'before' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/hyper/node_modules/ava/entrypoints/main")'.
- test/index.ts#L12 in tsconfig.json
error TS2339: Property 'after' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/hyper/node_modules/ava/entrypoints/main")'.
- test/index.ts#L39 in tsconfig.json
error TS2349: This expression is not callable.
error TS7006: Parameter 't' implicitly has an 'any' type.

andrewbranch · 2024-03-19T22:37:13Z

@typescript-bot test top200

typescript-bot · 2024-03-19T22:37:15Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	👀 Results

typescript-bot · 2024-03-19T23:35:47Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/57570/merge:

Something interesting changed - please have a look.

Details

microsoft/playwright

4 of 15 projects failed to build with the old tsc and were ignored

packages/html-reporter/tsconfig.json

error TS1192: Module '"/mnt/ts_downloads/_/m/playwright/node_modules/@zip.js/zip.js/index"' has no default export.
- packages/html-reporter/src/index.tsx#L18

typescript-bot assigned andrewbranch Feb 28, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 28, 2024

andrewbranch force-pushed the bug/54752 branch from 74fc5a5 to ab5d376 Compare February 28, 2024 22:22

andrewbranch added 3 commits March 4, 2024 09:56

Always set impliedNodeFormat; check what it should affect when refere…

945f396

…ncing

Update trace baselines

79f4953

Update unit test baselines

3c504d8

andrewbranch force-pushed the bug/54752 branch from ab5d376 to 3c504d8 Compare March 4, 2024 17:57

jakebailey mentioned this pull request Mar 5, 2024

Modify chunking code to make it more clearly resilient to being too big microsoft/typescript-error-deltas#139

Merged

andrewbranch force-pushed the bug/54752 branch from 8f3fbdb to 3eae883 Compare March 6, 2024 18:00

Experiment: use limited impliedNodeFormat for interop checking

8cd2f92

andrewbranch force-pushed the bug/54752 branch from 3eae883 to 8cd2f92 Compare March 6, 2024 18:31

andrewbranch added 2 commits March 6, 2024 15:11

JSON named imports are only unavailable in Node.js

9fbab44

Always emit based on file extension and package.json type

82929e8

DanielRosenwasser mentioned this pull request Mar 12, 2024

Design Meeting Notes, 3/8/2023 #57755

Closed

andrewbranch added 5 commits March 13, 2024 14:40

Clean up, update JSDoc

1ce2442

Add and use easier util

ad2bde0

Finish emit changes

6eeb28a

WIP

151d5dd

Fix some module resolution stuff

3419d7f

andrewbranch commented Mar 18, 2024

View reviewed changes

Merge branch 'main' into bug/54752

f745222

andrewbranch added 2 commits March 19, 2024 15:33

Fix interop for ESM importing definitely-CJS outside of Node.js

0ac4dd1

Merge branch 'main' into bug/54752

585367b

andrewbranch added 4 commits March 20, 2024 14:22

Restrict ESM syntax in CJS files in module preserve

0641b95

Merge branch 'main' into bug/54752

3e18e98

Renames and JSDoc

7ced29d

Merge branch 'main' into bug/54752

c1a2a40

andrewbranch closed this Mar 22, 2024

		import referencedSource from "../../lib/src/a"; // Error
		import referencedDeclaration from "../../lib/dist/a"; // Error

Set impliedNodeFormat in every module mode #57570

Set impliedNodeFormat in every module mode #57570

Conversation

andrewbranch commented Feb 28, 2024

andrewbranch commented Feb 28, 2024

typescript-bot commented Feb 28, 2024 • edited Loading

typescript-bot commented Feb 28, 2024 • edited Loading

typescript-bot commented Feb 28, 2024

tsc

tsserver

startup

typescript-bot commented Feb 28, 2024

andrewbranch commented Feb 28, 2024

typescript-bot commented Feb 28, 2024 • edited Loading

typescript-bot commented Feb 28, 2024

tsc

tsserver

startup

typescript-bot commented Mar 5, 2024

andrewbranch commented Mar 5, 2024

typescript-bot commented Mar 5, 2024 • edited Loading

typescript-bot commented Mar 5, 2024

jakebailey commented Mar 5, 2024

andrewbranch commented Mar 6, 2024

typescript-bot commented Mar 6, 2024 • edited Loading

typescript-bot commented Mar 6, 2024

Choose a reason for hiding this comment

andrewbranch commented Mar 18, 2024

typescript-bot commented Mar 18, 2024 • edited Loading

typescript-bot commented Mar 19, 2024

andrewbranch commented Mar 19, 2024

typescript-bot commented Mar 19, 2024 • edited Loading

typescript-bot commented Mar 19, 2024

Set `impliedNodeFormat` in every module mode #57570

Set `impliedNodeFormat` in every module mode #57570

typescript-bot commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Mar 5, 2024 •

edited

Loading

typescript-bot commented Mar 6, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Mar 19, 2024 •

edited

Loading