Consider annotated parameter with an initializer as optional when inferring from it #57708

Andarist · 2024-03-09T10:36:47Z

…erring from it

Andarist · 2024-03-09T10:37:16Z

src/compiler/checker.ts

@@ -36542,7 +36542,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
            const declaration = signature.parameters[i].valueDeclaration as ParameterDeclaration;
            const typeNode = getEffectiveTypeAnnotationNode(declaration);
            if (typeNode) {
-                const source = addOptionality(getTypeFromTypeNode(typeNode), /*isProperty*/ false, isOptionalDeclaration(declaration));
+                const source = addOptionality(getTypeFromTypeNode(typeNode), /*isProperty*/ false, hasInitializer(declaration) || isOptionalDeclaration(declaration));


this matches the logic used by getTypeOfParameter

…aram-with-initializer

jakebailey · 2024-09-25T20:24:43Z

@typescript-bot test it

typescript-bot · 2024-09-25T20:24:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-25T20:53:59Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-25T21:06:05Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/57708/merge:

Everything looks good!

typescript-bot · 2024-09-25T21:30:05Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,189k (± 0.71%)}	_{193,275k (± 0.74%)}	_~	_192,638k	_196,199k	_{p=1.000 n=6}
_{Parse Time}	_{1.96s (± 0.70%)}	_{1.94s (± 1.00%)}	_~	_1.91s	_1.96s	_{p=0.211 n=6}
_{Bind Time}	_{1.06s (± 1.25%)}	_{1.06s (± 0.98%)}	_~	_1.04s	_1.07s	_{p=1.000 n=6}
_{Check Time}	_{13.99s (± 0.29%)}	_{13.97s (± 0.30%)}	_~	_13.92s	_14.02s	_{p=0.373 n=6}
_{Emit Time}	_{4.13s (± 4.68%)}	_{4.01s (± 1.06%)}	_~	_3.94s	_4.06s	_{p=0.463 n=6}
_{Total Time}	_{21.14s (± 0.90%)}	_{20.97s (± 0.25%)}	_~	_20.90s	_21.03s	_{p=0.050 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,013k (± 0.00%)}	_{1,223,992k (± 0.00%)}	_~	_1,223,936k	_1,224,042k	_{p=0.378 n=6}
_{Parse Time}	_{7.89s (± 0.76%)}	_{7.92s (± 0.90%)}	_~	_7.84s	_8.03s	_{p=0.685 n=6}
_{Bind Time}	_{2.23s (± 0.77%)}	_{2.23s (± 0.74%)}	_~	_2.20s	_2.24s	_{p=0.506 n=6}
_{Check Time}	_{36.50s (± 0.34%)}	_{36.53s (± 0.30%)}	_~	_36.41s	_36.67s	_{p=0.575 n=6}
_{Emit Time}	_{17.93s (± 0.36%)}	_{17.97s (± 0.75%)}	_~	_17.83s	_18.18s	_{p=0.748 n=6}
_{Total Time}	_{64.56s (± 0.30%)}	_{64.64s (± 0.36%)}	_~	_64.43s	_65.02s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,037	_936,037	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,832k (± 0.00%)}	_{2,351,948k (± 0.01%)}	_~	_2,351,771k	_2,352,518k	_{p=0.810 n=6}
_{Parse Time}	_{13.56s (± 0.32%)}	_{13.56s (± 0.44%)}	_~	_13.47s	_13.61s	_{p=0.936 n=6}
_{Bind Time}	_{3.13s (± 0.40%)}	_{3.14s (± 0.60%)}	_~	_3.12s	_3.17s	_{p=0.357 n=6}
_{Check Time}	_{105.94s (± 0.41%)}	_{105.89s (± 1.43%)}	_~	_104.62s	_108.86s	_{p=0.173 n=6}
_{Emit Time}	_{0.39s (± 1.94%)}	_{0.39s (± 3.18%)}	_~	_0.37s	_0.40s	_{p=0.796 n=6}
_{Total Time}	_{123.02s (± 0.33%)}	_{122.97s (± 1.26%)}	_~	_121.61s	_125.98s	_{p=0.199 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,061	_1,250,061	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,970	_264,970	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,404,621k (± 0.03%)}	_{2,404,759k (± 0.03%)}	_~	_2,403,949k	_2,405,689k	_{p=0.810 n=6}
_{Parse Time}	_{6.09s (± 0.57%)}	_{6.09s (± 0.76%)}	_~	_6.05s	_6.18s	_{p=0.630 n=6}
_{Bind Time}	_{2.26s (± 0.56%)}	_{2.26s (± 0.87%)}	_~	_2.25s	_2.30s	_{p=1.000 n=6}
_{Check Time}	_{41.13s (± 0.71%)}	_{41.38s (± 1.12%)}	_~	_40.77s	_41.95s	_{p=0.378 n=6}
_{Emit Time}	_{3.69s (± 6.34%)}	_{3.61s (± 4.80%)}	_~	_3.46s	_3.86s	_{p=0.521 n=6}
_{Total Time}	_{53.19s (± 0.72%)}	_{53.37s (± 0.76%)}	_~	_52.91s	_53.86s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,061	_1,250,061	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,970	_264,970	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,479,627k (± 0.03%)}	_{2,479,427k (± 0.03%)}	_~	_2,478,653k	_2,480,455k	_{p=0.689 n=6}
_{Parse Time}	_{7.89s (± 0.63%)}	_{7.89s (± 0.54%)}	_~	_7.85s	_7.95s	_{p=0.810 n=6}
_{Bind Time}	_{2.54s (± 0.64%)}	_{2.54s (± 0.64%)}	_~	_2.52s	_2.57s	_{p=0.463 n=6}
_{Check Time}	_{51.53s (± 0.69%)}	_{51.64s (± 0.80%)}	_~	_51.03s	_52.09s	_{p=0.689 n=6}
_{Emit Time}	_{4.38s (± 1.03%)}	_{4.47s (± 4.11%)}	_~	_4.33s	_4.81s	_{p=0.748 n=6}
_{Total Time}	_{66.34s (± 0.59%)}	_{66.54s (± 0.54%)}	_~	_66.15s	_66.95s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,941	_260,941	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,385	_106,385	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{436,567k (± 0.01%)}	_{436,554k (± 0.02%)}	_~	_436,471k	_436,656k	_{p=0.689 n=6}
_{Parse Time}	_{2.85s (± 0.44%)}	_{2.85s (± 0.69%)}	_~	_2.84s	_2.89s	_{p=1.000 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.37%)}	_~	_1.08s	_1.09s	_{p=0.595 n=6}
_{Check Time}	_{15.41s (± 0.27%)}	_{15.42s (± 0.44%)}	_~	_15.35s	_15.52s	_{p=1.000 n=6}
_{Emit Time}	_{1.30s (± 1.23%)}	_{1.28s (± 1.78%)}	_~	_1.25s	_1.31s	_{p=0.164 n=6}
_{Total Time}	_{20.65s (± 0.19%)}	_{20.64s (± 0.29%)}	_~	_20.54s	_20.71s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,997k (± 0.04%)}	_{370,920k (± 0.02%)}	_~	_370,860k	_371,007k	_{p=0.298 n=6}
_{Parse Time}	_{2.28s (± 0.51%)}	_{2.28s (± 0.66%)}	_~	_2.27s	_2.31s	_{p=0.804 n=6}
_{Bind Time}	_{1.30s (± 1.49%)}	_{1.31s (± 1.58%)}	_~	_1.27s	_1.33s	_{p=0.465 n=6}
_{Check Time}	_{13.40s (± 0.33%)}	_{13.36s (± 0.22%)}	_~	_13.32s	_13.40s	_{p=0.147 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.98s (± 0.36%)}	_{16.95s (± 0.26%)}	_~	_16.88s	_17.00s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,103,645	_3,103,645	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,069,693	_1,069,693	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,198,991k (± 0.01%)}	_{3,198,762k (± 0.02%)}	_~	_3,198,143k	_3,199,162k	_{p=0.936 n=6}
_{Parse Time}	_{17.21s (± 0.23%)}	_{17.24s (± 0.41%)}	_~	_17.17s	_17.35s	_{p=0.419 n=6}
_{Bind Time}	_{5.35s (± 1.91%)}	_{5.31s (± 0.49%)}	_~	_5.28s	_5.35s	_{p=0.570 n=6}
_{Check Time}	_{100.04s (± 0.25%)}	_{100.27s (± 0.42%)}	_~	_99.84s	_100.81s	_{p=0.378 n=6}
_{Emit Time}	_{28.17s (± 7.13%)}	_{28.74s (± 6.98%)}	_~	_27.31s	_31.48s	_{p=0.470 n=6}
_{Total Time}	_{150.76s (± 1.34%)}	_{151.57s (± 1.48%)}	_~	_149.82s	_154.74s	_{p=0.873 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,997	_278,997	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,861	_113,861	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,443k (± 0.01%)}	_{428,427k (± 0.01%)}	_~	_428,376k	_428,494k	_{p=0.575 n=6}
_{Parse Time}	_{3.30s (± 0.46%)}	_{3.29s (± 0.51%)}	_~	_3.27s	_3.31s	_{p=0.566 n=6}
_{Bind Time}	_{1.43s (± 1.14%)}	_{1.43s (± 0.38%)}	_~	_1.43s	_1.44s	_{p=0.675 n=6}
_{Check Time}	_{15.00s (± 0.32%)}	_{15.01s (± 0.47%)}	_~	_14.93s	_15.13s	_{p=0.518 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.73s (± 0.23%)}	_{19.73s (± 0.38%)}	_~	_19.65s	_19.87s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,546k (± 0.01%)}	_{483,555k (± 0.01%)}	_~	_483,516k	_483,636k	_{p=0.936 n=6}
_{Parse Time}	_{3.22s (± 0.36%)}	_{3.21s (± 0.38%)}	_~	_3.20s	_3.23s	_{p=0.504 n=6}
_{Bind Time}	_{1.15s (± 0.55%)}	_{1.15s (± 0.65%)}	_~	_1.14s	_1.16s	_{p=0.718 n=6}
_{Check Time}	_{18.55s (± 0.33%)}	_{18.58s (± 0.25%)}	_~	_18.49s	_18.62s	_{p=0.421 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.92s (± 0.28%)}	_{22.95s (± 0.22%)}	_~	_22.85s	_22.99s	_{p=0.470 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-25T22:23:39Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/57708/merge:

Everything looks good!

Consider annotated parameter with an initializer as optional when inf…

7d1c95a

…erring from it

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 9, 2024

Andarist commented Mar 9, 2024

View reviewed changes

sandersn requested review from weswigham and navya9singh March 20, 2024 19:27

typescript-bot removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 20, 2024

sandersn assigned weswigham Mar 20, 2024

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 20, 2024

Merge remote-tracking branch 'origin/main' into fix/infer-annotated-p…

4159adc

…aram-with-initializer

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider annotated parameter with an initializer as optional when inferring from it #57708

Consider annotated parameter with an initializer as optional when inferring from it #57708

Andarist commented Mar 9, 2024

Andarist Mar 9, 2024

jakebailey commented Sep 25, 2024

typescript-bot commented Sep 25, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024

typescript-bot commented Sep 25, 2024

typescript-bot commented Sep 25, 2024

tsc

typescript-bot commented Sep 25, 2024

Consider annotated parameter with an initializer as optional when inferring from it #57708

Are you sure you want to change the base?

Consider annotated parameter with an initializer as optional when inferring from it #57708

Conversation

Andarist commented Mar 9, 2024

Andarist Mar 9, 2024

Choose a reason for hiding this comment

jakebailey commented Sep 25, 2024

typescript-bot commented Sep 25, 2024 • edited Loading

typescript-bot commented Sep 25, 2024

typescript-bot commented Sep 25, 2024

typescript-bot commented Sep 25, 2024

tsc

typescript-bot commented Sep 25, 2024

typescript-bot commented Sep 25, 2024 •

edited

Loading