do not report 'noImplicitReturns' error if inferred return type of th… #5824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e function is void/any
| @@ -9871,31 +9871,40 @@ namespace ts { | |||
| } | |||
|
|
|||
| // Functions with with an explicitly specified 'void' or 'any' return type don't need any return expressions. | |||
There was a problem hiding this comment.
remove "explicitly specified"
There was a problem hiding this comment.
'explicitly specified' reflects what is checked in the if below - if function has explicit type annotation and it is void / any
|
@DanielRosenwasser any other comments? |
| return; | ||
| } | ||
|
|
||
| // If all we have is a function signature, or an arrow function with an expression body, then there is nothing to check. | ||
| // also if HasImplicitReturnValue flags is not set this means that all codepaths in function body end with return of throw | ||
| // also if HasImplicitReturn flag is not set this means that all codepaths in function body end with return of throw |
|
👍 |
|
👍 |
|
Apart from @yuit's feedback 👍 |
vladima
added a commit
that referenced
this pull request
Dec 1, 2015
do not report 'noImplicitReturns' error if inferred return type of th…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e function is void/any. fixes #5814