Skip to content

Update knip #59182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Update knip #59182

merged 1 commit into from
Jul 8, 2024

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Jul 8, 2024

Sorry, no ticket. Reference: #56817 (comment). Let me know if I should still create one.

Follow-up to #56817. slim down Knip further.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 8, 2024
@jakebailey
Copy link
Member

Seems like 5.25 is broken; an old import left behind?

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/runner/work/TypeScript/TypeScript/node_modules/knip/vendor/bash-parser/index.js' imported from /home/runner/work/TypeScript/TypeScript/node_modules/knip/dist/binaries/bash-parser.js
    at finalizeResolution (node:internal/modules/esm/resolve:260:11)
    at moduleResolve (node:internal/modules/esm/resolve:921:10)
    at defaultResolve (node:internal/modules/esm/resolve:11[20](https://github.com/microsoft/TypeScript/actions/runs/9845364241/job/27180753018?pr=59182#step:5:21):11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:526:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:249:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:126:49) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///home/runner/work/TypeScript/TypeScript/node_modules/knip/vendor/bash-parser/index.js'
}

@webpro
Copy link
Contributor Author

webpro commented Jul 8, 2024

Thanks for the catch! Forgot to add vendor to package.json#files to publish. Same relative path so went unnoticed even in integration tests.

@webpro webpro marked this pull request as ready for review July 8, 2024 20:20
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jakebailey jakebailey merged commit eb23677 into microsoft:main Jul 8, 2024
29 checks passed
@webpro webpro deleted the knip-slim branch July 9, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants