Skip to content

Ignore skipLibCheck (experiment) #60427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Ignore skipLibCheck (experiment) #60427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80f0bf
Ignore skipLibCheck (experiment)
RyanCavanaugh Nov 5, 2024
d319e60
Oops
RyanCavanaugh Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/compiler/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10287,19 +10287,12 @@
}

function skipTypeCheckingWorker(
sourceFile: SourceFile,

Check warning on line 10290 in src/compiler/utilities.ts

View workflow job for this annotation

GitHub Actions / lint 

'sourceFile' is defined but never used. Allowed unused args must match /^(_+$|_[^_])/u
options: CompilerOptions,

Check warning on line 10291 in src/compiler/utilities.ts

View workflow job for this annotation

GitHub Actions / lint 

'options' is defined but never used. Allowed unused args must match /^(_+$|_[^_])/u
host: HostWithIsSourceOfProjectReferenceRedirect,

Check warning on line 10292 in src/compiler/utilities.ts

View workflow job for this annotation

GitHub Actions / lint 

'host' is defined but never used. Allowed unused args must match /^(_+$|_[^_])/u
ignoreNoCheck: boolean,

Check warning on line 10293 in src/compiler/utilities.ts

View workflow job for this annotation

GitHub Actions / lint 

'ignoreNoCheck' is defined but never used. Allowed unused args must match /^(_+$|_[^_])/u
) {
// If skipLibCheck is enabled, skip reporting errors if file is a declaration file.
// If skipDefaultLibCheck is enabled, skip reporting errors if file contains a
// '/// <reference no-default-lib="true"/>' directive.
return (options.skipLibCheck && sourceFile.isDeclarationFile ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been "true" to check if it was always on? Or were you looking to try and see if we never did this if things changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was trying to manifest opposite day

options.skipDefaultLibCheck && sourceFile.hasNoDefaultLib) ||
(!ignoreNoCheck && options.noCheck) ||
host.isSourceOfProjectReferenceRedirect(sourceFile.fileName) ||
!canIncludeBindAndCheckDiagnostics(sourceFile, options);
return false;
}

/** @internal */
Expand Down
Loading