Skip to content

MetaProperty is possibly nullish #60440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

MetaProperty is possibly nullish #60440

merged 1 commit into from
Nov 6, 2024

Conversation

RyanCavanaugh
Copy link
Member

Fixes #60439

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 6, 2024
jakebailey
jakebailey approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.7 backport?

@RyanCavanaugh
Copy link
Member Author

5.7 backport?

Not user-reported and seems very difficult to hit; don't think so

@RyanCavanaugh RyanCavanaugh merged commit 55f1248 into microsoft:main Nov 6, 2024
32 checks passed
@RyanCavanaugh RyanCavanaugh deleted the fix-60439 branch November 6, 2024 21:06
@jakebailey jakebailey mentioned this pull request Dec 16, 2024
Merged
jakebailey pushed a commit to jakebailey/TypeScript that referenced this pull request Dec 16, 2024
@RyanCavanaugh @jakebailey
MetaProperty is possibly nullish (microsoft#60440)
ee0eca7
DanielRosenwasser pushed a commit that referenced this pull request Dec 17, 2024
@jakebailey @Andarist @RyanCavanaugh
Cherry-pick #60402, #60440, #60616 into release-5.7 (#60777)
e844dc3 
Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: Ryan Cavanaugh <[email protected]>
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullish semantics missed MetaProperty
3 participants
@RyanCavanaugh @jakebailey @typescript-bot