Skip to content

DOM update 2025/01/29 #61073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2025
Merged

DOM update 2025/01/29 #61073

merged 4 commits into from
Jan 30, 2025

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jan 29, 2025 •
edited
Loading

I want this into nightly soon to make sure that
microsoft/TypeScript-DOM-lib-generator#1598 is good to ship for the RC. It changes return types of 5 functions from Promise<undefined> to Promise<void>. This should improve compatibility since it's the way the rest of the DOM is, but it's also been long enough that I want to check to make sure.

@sandersn
DOM update 2025/01/29
d3fbb1a 
This is going into nightly to make sure that
microsoft/TypeScript-DOM-lib-generator#1598

is goodto ship for the RC.
@sandersn
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 29, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: rusha
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rusha/index.d.ts
  19:11  error  TypeScript@local compile error: 
Interface 'RushaWorker' incorrectly extends interface 'Worker'.
  Types of property 'onmessage' are incompatible.
    Type '((this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void) | null' is not assignable to type '((this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any) | null'.
      Type '(this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void' is not assignable to type '(this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any'.
        The 'this' types of each signature are incompatible.
          Type 'MessageEventTarget<Worker>' is missing the following properties from type 'RushaWorker': postMessage, terminate, dispatchEvent, onerror  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<void>', but here has type 'Promise<undefined>'               @definitelytyped/expect
  7:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<void>', but here has type 'Promise<undefined>'            @definitelytyped/expect
  8:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<void>', but here has type 'Promise<undefined>'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)
Errors that changed between main and the branch:

Package: dom-webcodecs
Main error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Branch error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  505:6  error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@jakebailey
Copy link
Member

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 29, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
user test this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 193,127k (± 0.02%) 194,974k (± 1.04%) ~ 193,097k 196,977k p=0.173 n=6
Parse Time 1.31s 1.31s (± 0.39%) ~ 1.31s 1.32s p=0.174 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.76s (± 0.13%) 9.77s (± 0.16%) ~ 9.75s 9.79s p=0.328 n=6
Emit Time 2.73s (± 0.78%) 2.74s (± 0.95%) ~ 2.70s 2.78s p=0.868 n=6
Total Time 14.53s (± 0.24%) 14.54s (± 0.25%) ~ 14.50s 14.60s p=0.871 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 948,493 948,488 -5 (- 0.00%) ~ ~ p=0.001 n=6
Types 411,005 411,006 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 1,225,427k (± 0.00%) 1,225,423k (± 0.00%) ~ 1,225,365k 1,225,467k p=1.000 n=6
Parse Time 6.65s (± 0.79%) 6.67s (± 0.79%) ~ 6.57s 6.71s p=0.373 n=6
Bind Time 1.89s (± 0.54%) 1.89s (± 0.78%) ~ 1.87s 1.91s p=0.931 n=6
Check Time 31.97s (± 0.24%) 31.97s (± 0.33%) ~ 31.80s 32.11s p=0.936 n=6
Emit Time 15.21s (± 0.76%) 15.22s (± 0.27%) ~ 15.17s 15.29s p=1.000 n=6
Total Time 55.73s (± 0.18%) 55.75s (± 0.18%) ~ 55.63s 55.88s p=0.748 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,447,050 2,447,052 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Types 898,533 898,533 ~ ~ ~ p=1.000 n=6
Memory used 2,307,737k (± 0.00%) 2,307,821k (± 0.00%) +84k (+ 0.00%) 2,307,785k 2,307,862k p=0.005 n=6
Parse Time 8.91s (± 0.20%) 8.91s (± 0.19%) ~ 8.89s 8.93s p=0.737 n=6
Bind Time 2.17s (± 0.35%) 2.17s (± 0.38%) ~ 2.16s 2.18s p=0.432 n=6
Check Time 74.20s (± 0.33%) 74.16s (± 0.36%) ~ 73.86s 74.50s p=0.748 n=6
Emit Time 0.28s (± 1.45%) 0.28s (± 1.47%) ~ 0.27s 0.28s p=0.218 n=6
Total Time 85.57s (± 0.28%) 85.52s (± 0.30%) ~ 85.25s 85.84s p=0.689 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,362,063k (± 0.03%) 2,362,153k (± 0.02%) ~ 2,361,582k 2,362,732k p=0.575 n=6
Parse Time 5.24s (± 0.63%) 5.23s (± 1.32%) ~ 5.16s 5.36s p=0.688 n=6
Bind Time 1.78s (± 1.49%) 1.78s (± 0.87%) ~ 1.75s 1.79s p=0.746 n=6
Check Time 35.35s (± 0.41%) 35.37s (± 0.50%) ~ 35.20s 35.68s p=0.872 n=6
Emit Time 3.03s (± 1.29%) 3.02s (± 1.30%) ~ 2.98s 3.09s p=1.000 n=6
Total Time 45.39s (± 0.41%) 45.40s (± 0.55%) ~ 45.15s 45.84s p=0.810 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,795,780k (±14.25%) 3,038,799k (± 9.77%) ~ 2,431,990k 3,160,646k p=0.093 n=6
Parse Time 8.60s (± 1.88%) 8.68s (± 1.22%) ~ 8.52s 8.81s p=0.378 n=6
Bind Time 2.67s (± 1.00%) 2.68s (± 1.61%) ~ 2.63s 2.75s p=0.871 n=6
Check Time 53.09s (± 0.39%) 53.27s (± 0.73%) ~ 52.53s 53.59s p=0.173 n=6
Emit Time 4.42s (± 2.38%) 4.39s (± 1.60%) ~ 4.27s 4.48s p=0.470 n=6
Total Time 68.77s (± 0.49%) 69.01s (± 0.62%) ~ 68.20s 69.41s p=0.298 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,074 263,074 ~ ~ ~ p=1.000 n=6
Types 106,881 106,881 ~ ~ ~ p=1.000 n=6
Memory used 441,311k (± 0.02%) 441,318k (± 0.02%) ~ 441,226k 441,396k p=1.000 n=6
Parse Time 3.57s (± 1.25%) 3.56s (± 0.57%) ~ 3.55s 3.60s p=0.683 n=6
Bind Time 1.31s (± 1.12%) 1.32s (± 0.80%) ~ 1.30s 1.33s p=0.619 n=6
Check Time 18.98s (± 0.29%) 19.00s (± 0.61%) ~ 18.79s 19.10s p=0.418 n=6
Emit Time 1.52s (± 1.47%) 1.53s (± 1.13%) ~ 1.51s 1.55s p=0.316 n=6
Total Time 25.38s (± 0.18%) 25.41s (± 0.50%) ~ 25.19s 25.52s p=0.469 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,113 226,113 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,836k (± 0.06%) 371,739k (± 0.02%) ~ 371,664k 371,826k p=0.936 n=6
Parse Time 2.92s (± 1.44%) 2.91s (± 1.02%) ~ 2.87s 2.95s p=0.462 n=6
Bind Time 1.61s (± 1.54%) 1.60s (± 1.77%) ~ 1.57s 1.65s p=0.628 n=6
Check Time 16.47s (± 0.25%) 16.52s (± 0.52%) ~ 16.46s 16.68s p=0.688 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.00s (± 0.42%) 21.02s (± 0.45%) ~ 20.92s 21.19s p=0.936 n=6
vscode - node (v18.15.0, x64)
Errors 3 5 🔻+2 (+66.67%) ~ ~ p=0.001 n=6
Symbols 3,272,443 3,272,445 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Types 1,125,152 1,125,154 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 3,346,538k (± 0.01%) 3,346,589k (± 0.01%) ~ 3,346,360k 3,347,042k p=0.471 n=6
Parse Time 14.59s (± 0.33%) 14.59s (± 0.54%) ~ 14.53s 14.71s p=0.747 n=6
Bind Time 4.60s (± 0.39%) 4.60s (± 0.40%) ~ 4.58s 4.63s p=0.743 n=6
Check Time 91.64s (± 2.97%) 91.55s (± 2.94%) ~ 88.61s 96.34s p=0.873 n=6
Emit Time 28.43s (± 3.19%) 28.18s (± 9.19%) ~ 23.13s 30.00s p=0.298 n=6
Total Time 139.26s (± 2.18%) 138.93s (± 0.80%) ~ 137.46s 140.30s p=0.936 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 292,550 292,552 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Types 119,124 119,125 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 446,037k (± 0.04%) 446,115k (± 0.03%) ~ 445,934k 446,281k p=0.471 n=6
Parse Time 5.08s (± 1.63%) 5.07s (± 1.13%) ~ 4.99s 5.15s p=0.629 n=6
Bind Time 2.23s (± 0.93%) 2.21s (± 0.88%) -0.03s (- 1.19%) 2.18s 2.23s p=0.043 n=6
Check Time 23.48s (± 1.61%) 23.34s (± 0.31%) ~ 23.27s 23.44s p=0.748 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.81s (± 1.12%) 30.62s (± 0.25%) ~ 30.50s 30.71s p=0.126 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,449 555,448 -1 (- 0.00%) ~ ~ p=0.001 n=6
Types 186,146 186,146 ~ ~ ~ p=1.000 n=6
Memory used 494,540k (± 0.03%) 494,545k (± 0.03%) ~ 494,257k 494,632k p=1.000 n=6
Parse Time 3.41s (± 0.94%) 3.41s (± 0.60%) ~ 3.39s 3.44s p=0.806 n=6
Bind Time 1.21s (± 1.00%) 1.21s (± 1.34%) ~ 1.19s 1.23s p=0.462 n=6
Check Time 19.68s (± 0.83%) 19.75s (± 2.15%) ~ 19.50s 20.61s p=0.470 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.30s (± 0.69%) 24.37s (± 1.76%) ~ 24.10s 25.24s p=0.748 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61073/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

extensions/json-language-features/server/tsconfig.json

extensions/html-language-features/server/tsconfig.json

extensions/css-language-features/server/tsconfig.json

@sandersn
Copy link
Member Author

No new failures from this update, which means that it's good to merge.

However, rusha and vscode are failing with the MessagePort-related error that I thought was fixed. I need to see what's going on there.

@sandersn
Manually put WorkerEventMap members back
1a3d836 
See if it fixes DT/vscode compilation
@sandersn
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 29, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: rusha
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rusha/index.d.ts
  19:11  error  TypeScript@local compile error: 
Interface 'RushaWorker' incorrectly extends interface 'Worker'.
  Types of property 'onmessage' are incompatible.
    Type '((this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void) | null' is not assignable to type '((this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any) | null'.
      Type '(this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void' is not assignable to type '(this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any'.
        The 'this' types of each signature are incompatible.
          Type 'MessageEventTarget<Worker>' is missing the following properties from type 'RushaWorker': postMessage, terminate, dispatchEvent, onerror  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<void>', but here has type 'Promise<undefined>'               @definitelytyped/expect
  7:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<void>', but here has type 'Promise<undefined>'            @definitelytyped/expect
  8:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<void>', but here has type 'Promise<undefined>'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)
Errors that changed between main and the branch:

Package: dom-webcodecs
Main error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Branch error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  505:6  error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 193,777k (± 0.81%) 194,421k (± 0.96%) ~ 193,111k 196,830k p=0.630 n=6
Parse Time 1.31s (± 0.39%) 1.30s (± 1.43%) ~ 1.28s 1.32s p=0.796 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.78s (± 0.32%) 9.77s (± 0.22%) ~ 9.74s 9.80s p=0.466 n=6
Emit Time 2.72s (± 0.49%) 2.74s (± 0.43%) +0.02s (+ 0.73%) 2.72s 2.75s p=0.027 n=6
Total Time 14.54s (± 0.27%) 14.54s (± 0.12%) ~ 14.52s 14.56s p=0.934 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 948,493 948,494 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 411,005 411,006 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 1,225,395k (± 0.00%) 1,225,444k (± 0.00%) ~ 1,225,385k 1,225,505k p=0.128 n=6
Parse Time 6.67s (± 0.36%) 6.62s (± 1.10%) ~ 6.51s 6.69s p=0.293 n=6
Bind Time 1.88s (± 1.03%) 1.89s (± 0.99%) ~ 1.87s 1.92s p=0.681 n=6
Check Time 31.99s (± 0.43%) 31.93s (± 0.30%) ~ 31.81s 32.06s p=0.423 n=6
Emit Time 15.17s (± 0.24%) 15.24s (± 0.45%) ~ 15.12s 15.31s p=0.089 n=6
Total Time 55.71s (± 0.31%) 55.67s (± 0.20%) ~ 55.53s 55.78s p=0.468 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,447,050 2,447,054 +4 (+ 0.00%) ~ ~ p=0.001 n=6
Types 898,533 898,533 ~ ~ ~ p=1.000 n=6
Memory used 2,307,897k (± 0.00%) 2,307,963k (± 0.00%) ~ 2,307,752k 2,308,043k p=0.078 n=6
Parse Time 13.28s (± 0.78%) 13.29s (± 0.42%) ~ 13.18s 13.33s p=0.809 n=6
Bind Time 3.23s (± 0.91%) 3.23s (± 0.61%) ~ 3.20s 3.25s p=0.935 n=6
Check Time 109.78s (± 1.26%) 110.10s (± 1.80%) ~ 108.61s 112.90s p=0.689 n=6
Emit Time 0.42s (± 1.80%) 0.42s (± 2.13%) ~ 0.41s 0.43s p=0.798 n=6
Total Time 126.71s (± 1.14%) 127.04s (± 1.58%) ~ 125.55s 129.85s p=1.000 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,362,515k (± 0.02%) 2,362,209k (± 0.02%) ~ 2,361,817k 2,362,851k p=0.298 n=6
Parse Time 5.22s (± 1.03%) 5.22s (± 1.05%) ~ 5.15s 5.28s p=1.000 n=6
Bind Time 1.80s (± 0.30%) 1.79s (± 0.96%) ~ 1.77s 1.82s p=0.498 n=6
Check Time 35.27s (± 0.30%) 35.26s (± 0.30%) ~ 35.09s 35.42s p=0.872 n=6
Emit Time 3.02s (± 1.25%) 3.01s (± 1.06%) ~ 2.97s 3.06s p=0.573 n=6
Total Time 45.32s (± 0.34%) 45.28s (± 0.17%) ~ 45.16s 45.36s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 3,038,711k (± 9.75%) 3,038,677k (± 9.75%) ~ 2,433,341k 3,160,463k p=1.000 n=6
Parse Time 7.01s (± 1.43%) 7.00s (± 1.02%) ~ 6.88s 7.06s p=1.000 n=6
Bind Time 2.15s (± 1.91%) 2.15s (± 1.27%) ~ 2.10s 2.17s p=1.000 n=6
Check Time 43.02s (± 0.51%) 42.90s (± 0.44%) ~ 42.62s 43.09s p=0.423 n=6
Emit Time 3.46s (± 2.16%) 3.48s (± 1.50%) ~ 3.42s 3.56s p=0.575 n=6
Total Time 55.65s (± 0.53%) 55.53s (± 0.45%) ~ 55.08s 55.74s p=0.298 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,074 263,074 ~ ~ ~ p=1.000 n=6
Types 106,881 106,881 ~ ~ ~ p=1.000 n=6
Memory used 441,324k (± 0.01%) 441,298k (± 0.01%) ~ 441,261k 441,378k p=0.378 n=6
Parse Time 3.55s (± 0.61%) 3.57s (± 1.35%) ~ 3.50s 3.64s p=0.617 n=6
Bind Time 1.31s (± 0.48%) 1.32s (± 0.88%) ~ 1.31s 1.34s p=0.070 n=6
Check Time 19.02s (± 0.33%) 19.04s (± 0.51%) ~ 18.91s 19.19s p=0.747 n=6
Emit Time 1.53s (± 1.35%) 1.53s (± 1.09%) ~ 1.51s 1.55s p=0.737 n=6
Total Time 25.41s (± 0.23%) 25.46s (± 0.51%) ~ 25.24s 25.60s p=0.336 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,113 226,113 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,729k (± 0.01%) 371,798k (± 0.03%) ~ 371,712k 371,986k p=0.199 n=6
Parse Time 3.62s (± 0.54%) 3.62s (± 0.78%) ~ 3.59s 3.66s p=0.870 n=6
Bind Time 1.98s (± 0.45%) 1.97s (± 1.00%) ~ 1.94s 2.00s p=0.119 n=6
Check Time 20.45s (± 0.33%) 20.45s (± 0.38%) ~ 20.37s 20.56s p=0.688 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 26.06s (± 0.26%) 26.04s (± 0.31%) ~ 25.95s 26.14s p=0.630 n=6
vscode - node (v18.15.0, x64)
Errors 3 5 🔻+2 (+66.67%) ~ ~ p=0.001 n=6
Symbols 3,272,246 3,272,250 +4 (+ 0.00%) ~ ~ p=0.001 n=6
Types 1,125,114 1,125,116 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 3,346,744k (± 0.01%) 3,346,624k (± 0.01%) ~ 3,346,161k 3,346,913k p=0.298 n=6
Parse Time 14.60s (± 0.33%) 14.47s (± 0.65%) -0.13s (- 0.87%) 14.37s 14.63s p=0.037 n=6
Bind Time 4.60s (± 2.17%) 4.63s (± 2.75%) ~ 4.52s 4.80s p=0.936 n=6
Check Time 90.32s (± 1.46%) 89.51s (± 2.16%) ~ 87.78s 92.25s p=0.471 n=6
Emit Time 26.99s (± 7.48%) 27.56s (± 7.94%) ~ 23.42s 29.43s p=0.575 n=6
Total Time 136.51s (± 1.12%) 136.17s (± 1.46%) ~ 134.20s 139.40s p=0.471 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 292,550 292,554 +4 (+ 0.00%) ~ ~ p=0.001 n=6
Types 119,124 119,125 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 446,132k (± 0.02%) 446,063k (± 0.02%) ~ 445,973k 446,232k p=0.230 n=6
Parse Time 4.10s (± 0.86%) 4.08s (± 0.83%) ~ 4.04s 4.13s p=0.373 n=6
Bind Time 1.78s (± 1.05%) 1.78s (± 1.11%) ~ 1.75s 1.80s p=0.684 n=6
Check Time 18.78s (± 0.42%) 18.78s (± 0.23%) ~ 18.72s 18.85s p=0.872 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.67s (± 0.24%) 24.64s (± 0.13%) ~ 24.61s 24.69s p=0.372 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,449 555,450 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 186,146 186,146 ~ ~ ~ p=1.000 n=6
Memory used 494,586k (± 0.01%) 494,613k (± 0.01%) ~ 494,506k 494,711k p=0.689 n=6
Parse Time 3.41s (± 0.81%) 3.42s (± 0.31%) ~ 3.40s 3.43s p=0.324 n=6
Bind Time 1.22s (± 1.27%) 1.22s (± 1.27%) ~ 1.20s 1.24s p=0.931 n=6
Check Time 19.67s (± 0.39%) 19.69s (± 0.33%) ~ 19.61s 19.78s p=0.687 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.30s (± 0.27%) 24.32s (± 0.28%) ~ 24.25s 24.43s p=0.748 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61073/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

extensions/json-language-features/server/tsconfig.json

extensions/html-language-features/server/tsconfig.json

extensions/css-language-features/server/tsconfig.json

@sandersn
Copy link
Member Author

Re-adding the members of WorkerEventMap didn't help. We should merge this PR after I revert that commit, and I'll figure out the problem separately.

@sandersn
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started
user test this ✅ Started
run dt ✅ Started 👀 Results
perf test this faster ✅ Started ❌ Results

@typescript-bot
Copy link
Collaborator

@sandersn, the perf run you requested failed. You can check the log here.

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<void>', but here has type 'Promise<undefined>'               @definitelytyped/expect
  7:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<void>', but here has type 'Promise<undefined>'            @definitelytyped/expect
  8:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<void>', but here has type 'Promise<undefined>'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)
Errors that changed between main and the branch:

Package: dom-webcodecs
Main error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Branch error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  505:6  error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@sandersn
Copy link
Member Author

rusha is fixed, which is indicative that vscode will also be fixed when I can get a run of it.

@jakebailey
Copy link
Member

@typescript-bot test top400
@typescript-bot user test this
@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 196,854k (± 0.12%) 195,650k (± 0.93%) ~ 193,295k 196,949k p=0.173 n=6
Parse Time 1.61s (± 0.88%) 1.60s (± 1.88%) ~ 1.54s 1.62s p=0.568 n=6
Bind Time 0.88s (± 0.86%) 0.88s (± 0.85%) ~ 0.87s 0.89s p=0.487 n=6
Check Time 11.83s (± 0.82%) 11.78s (± 0.44%) ~ 11.69s 11.84s p=0.687 n=6
Emit Time 3.31s (± 1.25%) 3.33s (± 2.93%) ~ 3.26s 3.52s p=0.810 n=6
Total Time 17.63s (± 0.71%) 17.59s (± 0.79%) ~ 17.37s 17.80s p=1.000 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 948,493 948,488 -5 (- 0.00%) ~ ~ p=0.001 n=6
Types 411,005 411,006 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 1,225,473k (± 0.00%) 1,225,472k (± 0.00%) ~ 1,225,412k 1,225,542k p=0.936 n=6
Parse Time 6.65s (± 0.90%) 6.63s (± 1.01%) ~ 6.54s 6.70s p=0.572 n=6
Bind Time 1.89s (± 0.43%) 1.89s (± 0.91%) ~ 1.86s 1.91s p=0.677 n=6
Check Time 32.03s (± 0.15%) 31.95s (± 0.37%) ~ 31.77s 32.10s p=0.226 n=6
Emit Time 15.21s (± 0.58%) 15.17s (± 0.42%) ~ 15.10s 15.27s p=0.574 n=6
Total Time 55.78s (± 0.18%) 55.64s (± 0.39%) ~ 55.29s 55.82s p=0.166 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,447,081 2,447,083 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Types 898,548 898,548 ~ ~ ~ p=1.000 n=6
Memory used 2,308,046k (± 0.00%) 2,308,049k (± 0.01%) ~ 2,307,823k 2,308,213k p=0.810 n=6
Parse Time 10.75s (± 0.33%) 10.79s (± 0.34%) ~ 10.75s 10.86s p=0.090 n=6
Bind Time 2.63s (± 0.83%) 2.63s (± 0.92%) ~ 2.60s 2.66s p=0.868 n=6
Check Time 89.05s (± 0.75%) 88.94s (± 0.35%) ~ 88.59s 89.34s p=0.471 n=6
Emit Time 0.35s (± 2.35%) 0.72s (±127.11%) ~ 0.34s 2.59s p=0.796 n=6
Total Time 102.78s (± 0.67%) 103.08s (± 0.97%) ~ 102.30s 105.02s p=1.000 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,362,265k (± 0.01%) 2,362,084k (± 0.02%) ~ 2,361,171k 2,362,737k p=0.810 n=6
Parse Time 5.26s (± 0.48%) 5.23s (± 0.88%) ~ 5.18s 5.30s p=0.520 n=6
Bind Time 1.80s (± 0.65%) 1.78s (± 1.04%) ~ 1.76s 1.81s p=0.105 n=6
Check Time 35.26s (± 0.39%) 35.28s (± 0.25%) ~ 35.16s 35.42s p=1.000 n=6
Emit Time 3.02s (± 1.63%) 2.99s (± 1.34%) ~ 2.92s 3.04s p=0.260 n=6
Total Time 45.33s (± 0.25%) 45.29s (± 0.17%) ~ 45.19s 45.42s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,429,394k (± 0.01%) 2,429,233k (± 0.02%) ~ 2,428,731k 2,429,717k p=0.471 n=6
Parse Time 5.43s (± 0.97%) 5.47s (± 0.65%) ~ 5.42s 5.52s p=0.297 n=6
Bind Time 1.77s (± 0.29%) 1.80s (± 1.15%) +0.03s (+ 1.60%) 1.77s 1.82s p=0.021 n=6
Check Time 35.31s (± 0.26%) 35.30s (± 0.35%) ~ 35.15s 35.47s p=0.936 n=6
Emit Time 3.06s (± 0.96%) 3.08s (± 1.71%) ~ 3.01s 3.15s p=0.936 n=6
Total Time 45.59s (± 0.28%) 45.64s (± 0.29%) ~ 45.47s 45.83s p=0.575 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,074 263,074 ~ ~ ~ p=1.000 n=6
Types 106,881 106,881 ~ ~ ~ p=1.000 n=6
Memory used 441,359k (± 0.03%) 441,311k (± 0.00%) ~ 441,292k 441,326k p=0.936 n=6
Parse Time 2.91s (± 0.43%) 2.90s (± 0.74%) ~ 2.87s 2.93s p=0.453 n=6
Bind Time 1.11s 1.11s ~ ~ ~ p=1.000 n=6
Check Time 15.81s (± 0.49%) 15.85s (± 0.25%) ~ 15.79s 15.90s p=0.261 n=6
Emit Time 1.32s (± 1.39%) 1.32s (± 0.80%) ~ 1.30s 1.33s p=0.324 n=6
Total Time 21.15s (± 0.39%) 21.17s (± 0.28%) ~ 21.11s 21.26s p=0.575 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,113 226,113 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,734k (± 0.01%) 371,928k (± 0.07%) ~ 371,712k 372,387k p=0.078 n=6
Parse Time 3.62s (± 0.64%) 3.59s (± 1.23%) ~ 3.53s 3.64s p=0.375 n=6
Bind Time 1.97s (± 1.55%) 1.97s (± 0.94%) ~ 1.96s 2.01s p=0.871 n=6
Check Time 20.44s (± 0.24%) 20.45s (± 0.18%) ~ 20.41s 20.50s p=0.623 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 26.03s (± 0.30%) 26.03s (± 0.24%) ~ 25.95s 26.13s p=1.000 n=6
vscode - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 3,273,248 3,273,250 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Types 1,125,534 1,125,536 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 3,347,429k (± 0.01%) 3,347,223k (± 0.01%) ~ 3,346,899k 3,347,614k p=0.689 n=6
Parse Time 18.03s (± 0.37%) 18.01s (± 0.55%) ~ 17.90s 18.19s p=0.422 n=6
Bind Time 5.62s (± 0.50%) 5.62s (± 0.29%) ~ 5.60s 5.64s p=1.000 n=6
Check Time 108.03s (± 0.33%) 109.42s (± 1.61%) ~ 107.75s 112.04s p=0.093 n=6
Emit Time 34.13s (± 2.08%) 34.98s (± 2.63%) ~ 33.70s 35.79s p=0.173 n=6
Total Time 165.82s (± 0.52%) 168.02s (± 1.17%) +2.20s (+ 1.33%) 165.75s 171.44s p=0.020 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 292,550 292,552 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Types 119,124 119,125 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 446,150k (± 0.02%) 446,176k (± 0.03%) ~ 445,996k 446,398k p=0.936 n=6
Parse Time 4.10s (± 0.85%) 4.10s (± 1.08%) ~ 4.05s 4.16s p=0.872 n=6
Bind Time 1.78s (± 1.03%) 1.79s (± 0.67%) ~ 1.78s 1.81s p=0.323 n=6
Check Time 18.84s (± 0.42%) 18.87s (± 0.41%) ~ 18.79s 18.98s p=0.630 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.73s (± 0.46%) 24.76s (± 0.40%) ~ 24.65s 24.92s p=0.688 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,449 555,448 -1 (- 0.00%) ~ ~ p=0.001 n=6
Types 186,146 186,146 ~ ~ ~ p=1.000 n=6
Memory used 494,592k (± 0.01%) 494,594k (± 0.01%) ~ 494,537k 494,644k p=0.689 n=6
Parse Time 3.42s (± 0.50%) 3.42s (± 0.32%) ~ 3.40s 3.43s p=0.933 n=6
Bind Time 1.20s (± 0.68%) 1.20s (± 1.55%) ~ 1.17s 1.22s p=0.739 n=6
Check Time 19.67s (± 0.47%) 19.73s (± 0.40%) ~ 19.61s 19.82s p=0.335 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.29s (± 0.38%) 24.35s (± 0.37%) ~ 24.23s 24.46s p=0.336 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 30, 2025
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

@sandersn
Copy link
Member Author

OK, I think everything is ready here, although I need to go fix the output of DOM-lib-generator to be this: T in the right places.

@sandersn sandersn merged commit 66e1b24 into microsoft:main Jan 30, 2025
32 checks passed
@sandersn sandersn deleted the dom-update-2025-01-29 branch January 30, 2025 19:39
@gineika gineika mentioned this pull request Mar 12, 2025
Closed
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandersn @typescript-bot @jakebailey