Fix #7611: Add support for String Literal Types in find all refs and occurances #8366
+219
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const references: ReferenceEntry[] = []; | ||
|
|
||
| forEach(sourceFiles, sourceFile => { |
|
Can you add a test where an ordinary string literal (of type |
|
@DanielRosenwasser any more comments? |
| const declarations = symbol.getDeclarations(); | ||
| if (declarations && declarations.length > 0) { | ||
| // Disallow rename for elements that are defined in the standard TypeScript library. | ||
| if (forEach(declarations, isDefinedInLibraryFile)) { |
There was a problem hiding this comment.
You should just do a pass at the end for all the references you get, instead of doing this logic here and below
|
I meant a test in which contextually typed strings are considered references, but others of the same content are not. Other than that and my last feedback, looks great 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7611