Skip to content

exclude outDir and add more default excludes #8703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2016
Merged

exclude outDir and add more default excludes #8703

merged 2 commits into from
May 20, 2016

Conversation

zhengbli
Copy link
Contributor

Fixes #8249

@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2016

can you add a unit test for this.

@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2016

actually for all the excluded directories, since you are at it,

@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2016

other than that 👍

@zhengbli zhengbli merged commit f95f51f into microsoft:master May 20, 2016
@zhengbli zhengbli deleted the excludeOutDir branch May 20, 2016 00:41
@jsamr jsamr mentioned this pull request Nov 17, 2017
Open
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbli @mhegazy @msftclas