Skip to content

Update diagnosticMessages.json #8997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update diagnosticMessages.json #8997

wants to merge 1 commit into from

Conversation

texastoland
Copy link
Contributor

Fixes #8996

@msftclas
Copy link

msftclas commented Jun 6, 2016

Hi @AppShipIt, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@texastoland
Copy link
Contributor Author

Forgot tests…

@mhegazy
Copy link
Contributor

mhegazy commented Jun 6, 2016

you also need to change the error message ids used in the code. e.g.

src/compiler/checker.ts(16217,62): error TS2339: Property 'Import_assignment_cannot_be_used_when_targeting_ECMAScript_6_modules_Consider_using_import_Asterisk_as_ns_from_mod_import_a_from_mod_import_d_from_mod_or_another_module_format_instead' does not exist on type '{ Unterminated_string_literal: { code: number; category: DiagnosticCategory; key: string; message...'.

since now the ID is Import_assignment_cannot_be_used_when_targeting_ECMAScript_2015_modules_Consider_using_import_Asterisk_as_ns_from_mod_import_a_from_mod_import_d_from_mod_or_another_module_format_instead

after that, do:

jake runtests
jake baseline-accept

and this should update all the failed test baselines

@mhegazy
Copy link
Contributor

mhegazy commented Jun 9, 2016

closing for now. please resubmit with the missing files.

@mhegazy mhegazy closed this Jun 9, 2016
@texastoland texastoland deleted the patch-1 branch June 10, 2016 02:51
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants