Skip to content

Add test to confirm that executor timeout preserves kernel state #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024
+18 −1
Merged

Add test to confirm that executor timeout preserves kernel state #1885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6334a89
Executor timeout should preserve kernel state
jackgerrits Mar 6, 2024
91561c8
Merge branch 'main' into timeout_state_check
jackgerrits Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion test/coding/test_embedded_ipython_code_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import sys
from pathlib import Path
import tempfile
from typing import Dict, Union
from typing import Dict, Type, Union
import uuid
import pytest
from autogen.agentchat.conversable_agent import ConversableAgent
Expand Down Expand Up @@ -175,6 +175,23 @@ def test_save_image(cls) -> None:
assert f"Image data saved to {code_result.output_files[0]}" in code_result.output


@pytest.mark.skipif(skip, reason=skip_reason)
@pytest.mark.parametrize("cls", classes_to_test)
def test_timeout_preserves_kernel_state(cls: Type[CodeExecutor]) -> None:
executor = cls(timeout=1)
code_blocks = [CodeBlock(code="x = 123", language="python")]
code_result = executor.execute_code_blocks(code_blocks)
assert code_result.exit_code == 0 and code_result.output.strip() == ""

code_blocks = [CodeBlock(code="import time; time.sleep(10)", language="python")]
code_result = executor.execute_code_blocks(code_blocks)
assert code_result.exit_code != 0 and "Timeout" in code_result.output

code_blocks = [CodeBlock(code="print(x)", language="python")]
code_result = executor.execute_code_blocks(code_blocks)
assert code_result.exit_code == 0 and "123" in code_result.output


@pytest.mark.skipif(skip, reason=skip_reason)
@pytest.mark.parametrize("cls", classes_to_test)
def test_save_html(cls) -> None:
Expand Down