Skip to content

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Mar 20, 2024

Why are these changes needed?

When fixing this test error: https://github.com/microsoft/autogen/actions/runs/8349926930/job/22855210369?pr=2078
I tried to simplify the work needed when creating a new agent with custom reply function.

  • enrich register_reply and simplify user's code;
  • bug fix in gpt assistant agent

Related issue number

#2078 #2005

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (5b57271) to head (cd967e0).
Report is 2191 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2095       +/-   ##
===========================================
+ Coverage   36.88%   60.98%   +24.09%     
===========================================
  Files          68       68               
  Lines        7062     7061        -1     
  Branches     1540     1669      +129     
===========================================
+ Hits         2605     4306     +1701     
+ Misses       4228     2365     -1863     
- Partials      229      390      +161     
Flag Coverage Δ
unittests 60.67% <100.00%> (+23.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonichi sonichi requested a review from lalo March 20, 2024 13:49
@sonichi sonichi added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 42d41a0 Mar 20, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@jackgerrits jackgerrits deleted the i2078 branch September 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants