Set WaterfallStepContext.Parent correctly #4480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDahlvang
force-pushed
the
eric/fixWaterfallStepContextParent
branch
from
8e56f6c to
714e9af
Compare
cleemullins
approved these changes
Aug 20, 2020
cleemullins
approved these changes
Aug 20, 2020
EricDahlvang
added a commit
that referenced
this pull request
Aug 20, 2020
* Set WaterfallStepContext.Parent correctly * Add test verifying the waterfall step parent is the waterfall dialogs parent * Remove uneeded test class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet sdk version of: microsoft/botbuilder-js#2714
for more info see:
#3855