Skip to content

fix new line in string interpolation #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 2, 2020
Merged

fix new line in string interpolation #4551

merged 9 commits into from
Sep 2, 2020

Conversation

cosmicshuai
Copy link
Contributor

fixes: #4547

now string interpolation in adaptive expressions:

'`${hello} \n\n ${world}`'

will return:

"hello 

  world"

@cosmicshuai cosmicshuai requested a review from a team as a code owner August 31, 2020 10:26
@boydc2014 boydc2014 merged commit 24d9508 into main Sep 2, 2020
@boydc2014 boydc2014 deleted the shuwan/fixNLInStrInterp branch September 2, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

+1 more reviewer

@Danieladu Danieladu Danieladu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi-line string in string interpolation
3 participants
@cosmicshuai @boydc2014 @Danieladu