Skip to content

Fix facebook and webex functional test pipelines #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2020
Merged

Fix facebook and webex functional test pipelines #4583

merged 7 commits into from
Sep 9, 2020

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Sep 3, 2020 •
edited
Loading

This fixes the broken pipeline Botbuilder-DotNet-Facebook-Functional-Tests-yaml, making the test (1) execute and (2) pass.

This also fixes the broken pipeline BotBuilder-DotNet-Webex-Functional-Test-yaml, making the test (1) execute and (2) pass.

Squashed commit of the following:
81cdbdf 
commit aea05ac
Merge: 640594a 1a49139
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Sep 3 16:16:41 2020 -0700

    Merge branch 'main' into v-bruhal/functestfixes8-13

commit 640594a
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Sep 2 17:30:11 2020 -0700

    Improve RefreshAccessToken error handling

commit 8298920
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Sep 2 16:36:21 2020 -0700

    Fix unit test SendMessageAsyncShouldThrowAnExceptionWithWrongPath

commit cf3800f
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Sep 2 11:47:43 2020 -0700

    Cleanup

commit 598d6f4
Author: BruceHaley <[email protected]>
Date:   Wed Sep 2 11:13:39 2020 -0700

    Update appsettings.json

commit 550947f
Author: BruceHaley <[email protected]>
Date:   Wed Sep 2 11:12:00 2020 -0700

    Delete tasks.json

commit d947a59
Author: BruceHaley <[email protected]>
Date:   Wed Sep 2 11:11:01 2020 -0700

    Delete launch.json

commit 93a9b8b
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Sep 2 10:55:43 2020 -0700

    Remove task 'Set values in appsettings.json file'

commit f3b8ed5
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 16:37:16 2020 -0700

    Switch to --mode Incremental

commit e5a5e6c
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 16:35:14 2020 -0700

    Fix call az deployment parameters

commit b7c75da
Merge: 9305dde c206994
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 14:41:55 2020 -0700

    Merge branch 'v-bruhal/functestfixes8-13' of https://github.com/microsoft/botbuilder-dotnet into v-bruhal/functestfixes8-13

commit 9305dde
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 14:39:17 2020 -0700

    Set deployment --mode Complete

commit c206994
Author: BruceHaley <[email protected]>
Date:   Tue Sep 1 10:45:36 2020 -0700

    Update WebexClientTest.cs

commit dfea1e8
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 10:40:23 2020 -0700

    Capture inner exception

commit f13d522
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 10:10:11 2020 -0700

    Clean up line 51

commit bb5d9f2
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 09:33:33 2020 -0700

    Add comment

commit 5e1406c
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Sep 1 09:24:33 2020 -0700

    Change to HttpRequestException

commit 5bf5f27
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 31 12:22:44 2020 -0700

    Fix exception format

commit c9553d8
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 31 11:47:52 2020 -0700

    Have SendMessageAsync() throw an exception on error.

commit 97c1e51
Author: LocalizationBuildProcess <[email protected]>
Date:   Fri Aug 28 14:47:13 2020 -0700

    Add diagnostics to FacebookClientWrapper.cs

commit f0033d6
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Aug 25 17:40:21 2020 -0700

    Drop 'Tag build if DeleteResourceGroup is false'

commit 7250141
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 24 16:27:23 2020 -0700

    Create resources doing double. Comment out option 1.

commit c2daddc
Merge: 666324f 84cdba5
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 24 10:45:54 2020 -0700

    Merge branch 'main' into v-bruhal/functestfixes8-13

commit 666324f
Author: LocalizationBuildProcess <[email protected]>
Date:   Fri Aug 21 16:23:28 2020 -0700

    Add tag build

commit cd488d6
Merge: d6ca630 c83869c
Author: LocalizationBuildProcess <[email protected]>
Date:   Fri Aug 21 14:17:44 2020 -0700

    Merge branch 'main' into v-bruhal/functestfixes8-13

commit d6ca630
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Aug 19 16:04:13 2020 -0700

    Add Dir workspace

commit 5395259
Merge: 7aec78c 2bef3d4
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Aug 19 10:24:13 2020 -0700

    Merge from master

commit 7aec78c
Merge: 522d591 54cc026
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Aug 18 15:59:51 2020 -0700

    Merge branch 'master' into v-bruhal/functestfixes8-13

commit 522d591
Author: LocalizationBuildProcess <[email protected]>
Date:   Tue Aug 18 10:11:34 2020 -0700

    Add dir workspace

commit 5b875c4
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 17 18:52:02 2020 -0700

    Try option 2 of "Create Azure Resources"

commit 96c21f5
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 17 18:49:51 2020 -0700

    Delete redundant task "Zip Deploy Bot"

commit 4c21c4d
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 17 18:36:35 2020 -0700

    Add comment

commit 5a40996
Author: LocalizationBuildProcess <[email protected]>
Date:   Mon Aug 17 12:04:42 2020 -0700

    Add try-catch for better RefreshAccessToken() error logging.

commit 7ca6d50
Author: LocalizationBuildProcess <[email protected]>
Date:   Fri Aug 14 10:44:07 2020 -0700

    Tweak env var for facebook

commit d2ef884
Author: LocalizationBuildProcess <[email protected]>
Date:   Fri Aug 14 10:41:14 2020 -0700

    Set up env vars for facebook tests

commit 2e652be
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 19:28:44 2020 -0700

    Put conditional aon Tag build

commit b8492c6
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 19:16:03 2020 -0700

    Replace Assert.Inconclusive with Assert.Fail in FacebookChatTersts.cs

commit 45ea7ed
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 19:02:24 2020 -0700

    Change Assert.Inconclusinve to Assert.Fail in WebexCleintTest.cs

commit a1a8499
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 18:39:51 2020 -0700

    Revert WebexClientTest.cs

commit 26d3df3
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 18:14:29 2020 -0700

    Add WebexTestBotWebexRoomId and others to dotnet test env vars

commit 94e51da
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 17:26:36 2020 -0700

    Change Assert.Inconclusive to Assert.Fail in WebexClientTest.cs

commit 0fae5ed
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 16:54:42 2020 -0700

    Remove var ReleasePackageVersion from builds

commit ef572d8
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 16:12:44 2020 -0700

    Fix webex typo

commit de8b485
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 16:06:46 2020 -0700

    Done with tests windows

commit e991fad
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 15:15:10 2020 -0700

    Webex done.

commit 48c7633
Author: LocalizationBuildProcess <[email protected]>
Date:   Thu Aug 13 14:03:40 2020 -0700

    Webex test .yml partly done.

commit 38b38fe
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Aug 12 19:09:14 2020 -0700

    Facebook completed

commit 282d6cb
Author: LocalizationBuildProcess <[email protected]>
Date:   Wed Aug 12 13:16:42 2020 -0700

    Fix dependsOn in new-rg templates
@BruceHaley BruceHaley merged commit d4861b8 into main Sep 9, 2020
@BruceHaley BruceHaley deleted the bruce/functestfixes9-3b branch September 9, 2020 01:21
@BruceHaley BruceHaley mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog Awaiting requested review from gabog

@garypretty garypretty Awaiting requested review from garypretty

1 more reviewer

@mrivera-ms mrivera-ms mrivera-ms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceHaley @mrivera-ms