Skip to content

[Facebook and Webex adapter functional test] Validate required variables to correct inconclusive results #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2020
Merged

[Facebook and Webex adapter functional test] Validate required variables to correct inconclusive results #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec4cb24
variable validation and skip conditions
Sep 2, 2020
343a404
Reorder AppId var and remove unnecessary condition
santgr11 Sep 4, 2020
06c381c
Merge branch 'main' into southworks/add/adapter-variables-validation
santgr11 Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions build/yaml/botbuilder-dotnet-ci-facebook-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,43 @@ variables:
# FacebookTestBotBotName: define this in Azure
# FacebookTestBotFacebookAccessToken: define this in Azure
# FacebookTestBotFacebookAppSecret: define this in Azure
# FacebookTestBotFacebookVerifyToken: define this in Azure
# FacebookTestBotFacebookVerifyToken: (optional) define this in Azure. Useful for webhook testing for un-deleted resources post-execution.
# FacebookTestBotSenderId: define this in Azure?: This var not needed in build 156862. Revisit this after the build's test is fixed & running.

steps:
- powershell: 'gci env:* | sort-object name | Format-Table -AutoSize -Wrap'
displayName: 'Display env vars'

- powershell: |
$InvalidVariables = $FALSE
$Message = "Required variable 'REPLACE_VARIABLE' either null, empty or whitespaced. Please set up this variable in the pipeline configuration."

if(!"$env:FacebookTestBotAppId".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotAppId")}
if(!"$env:FacebookTestBotAppSecret".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotAppSecret")}
if(!"$env:AzureSubscription".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "AzureSubscription")}
if(!"$env:FacebookTestBotBotGroup".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotBotGroup")}
if(!"$env:FacebookTestBotBotName".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotBotName")}
if(!"$env:FacebookTestBotFacebookAccessToken".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotFacebookAccessToken")}
if(!"$env:FacebookTestBotFacebookAppSecret".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotFacebookAppSecret")}
if(!"$env:FacebookTestBotSenderId".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "FacebookTestBotSenderId")}

if($InvalidVariables){
Write-Host "##vso[task.setvariable variable=InvalidVariables;]true"
Write-Host "##vso[task.complete result=Failed;]DONE"
}
displayName: Validate variables

- powershell: |
# Set values in appsettings.json file.
$file = "$(Build.SourcesDirectory)\tests\Adapters\Microsoft.Bot.Builder.Adapters.Facebook.PrimaryTestBot\appsettings.json";

$content = Get-Content -Raw $file | ConvertFrom-Json;
$content.FacebookVerifyToken = "$(FacebookTestBotFacebookVerifyToken)";
$content.FacebookAppSecret = "$(FacebookTestBotFaceBookAppSecret)";
$content.FacebookAccessToken = "$(FacebookTestBotFacebookAccessToken)";
$content | ConvertTo-Json | Set-Content $file;
displayName: 'Set values in appsettings.json file.'

- task: DotNetCoreCLI@2
displayName: 'dotnet publish testbot'
inputs:
Expand Down Expand Up @@ -101,7 +131,7 @@ steps:
azureSubscription: '$(AzureSubscription)'
scriptLocation: inlineScript
inlineScript: 'call az group delete -n "$(BotGroup)" --yes'
condition: and(always(), ne(variables['DeleteResourceGroup'], 'false'))
condition: and(always(), ne(variables['DeleteResourceGroup'], 'false'), ne(variables.InvalidVariables, 'true'))

- script: |
cd ..
Expand Down
24 changes: 23 additions & 1 deletion build/yaml/botbuilder-dotnet-ci-webex-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,28 @@ steps:
- powershell: 'gci env:* | sort-object name | Format-Table -AutoSize -Wrap'
displayName: 'Display env vars'

- powershell: |
$InvalidVariables = $FALSE
$Message = "Required variable 'REPLACE_VARIABLE' either null, empty or whitespaced. Please set up this variable in the pipeline configuration."

if(!"$env:WebexTestBotAppSecret".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotAppSecret")}
if(!"$env:WebexTestBotBotGroup".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotBotGroup")}
if(!"$env:WebexTestBotBotName".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotBotName")}
if(!"$env:WebexTestBotRefreshToken".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotRefreshToken")}
if(!"$env:WebexTestBotWebexBotAccessToken".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexBotAccessToken")}
if(!"$env:WebexTestBotWebexBotUserName".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexBotUserName")}
if(!"$env:WebexTestBotWebexIntegrationClientId".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexIntegrationClientId")}
if(!"$env:WebexTestBotWebexIntegrationClientSecret".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexIntegrationClientSecret")}
if(!"$env:WebexTestBotWebexRoomId".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexRoomId")}
if(!"$env:WebexTestBotWebexWebhookName".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexWebhookName")}
if(!"$env:WebexTestBotWebexWebhookSecret".Trim()) {$InvalidVariables = $TRUE; Write-Host $Message.replace("REPLACE_VARIABLE", "WebexTestBotWebexWebhookSecret")}

if($InvalidVariables){
Write-Host "##vso[task.setvariable variable=InvalidVariables;]true"
Write-Host "##vso[task.complete result=Failed;]DONE"
}
displayName: Validate variables

- task: DotNetCoreCLI@2
displayName: 'dotnet publish'
inputs:
Expand Down Expand Up @@ -107,7 +129,7 @@ steps:
azureSubscription: '$(AzureSubscription)'
scriptLocation: inlineScript
inlineScript: 'call az group delete -n "$(BotGroup)" --yes'
condition: and(always(), ne(variables['DeleteResourceGroup'], 'false'))
condition: and(always(), ne(variables['DeleteResourceGroup'], 'false'), ne(variables.InvalidVariables, 'true'))

- script: |
cd ..
Expand Down