Add catch for JsonException in GetBodyContent. #4596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnataylor
approved these changes
Sep 4, 2020
gabog
added a commit
that referenced
this pull request
Sep 4, 2020
gabog
added a commit
that referenced
this pull request
Sep 4, 2020
EricDahlvang
reviewed
Sep 4, 2020
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpClient.cs
Show resolved
Hide resolved
cleemullins
pushed a commit
that referenced
this pull request
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4556
Description
Added a catch for JsonExeption in GetBodyContent (this catch was in 4.7 but was removed in 4.8 when BotFrameworkHttpClient was refactored).
This catch allows the user to check the status code of the response (but the content won't be returned because its type us unknown).