Refactored and cleaned up ShowTypingMiddleware #4701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added virtual CreateTurnContext method to TestAdapter (that method is present in JS) to make it easier to manipulate the TrunContext in tests. Renamed and cleaned up ShowTypingMiddlewareTests.
johnataylor
approved these changes
Sep 24, 2020
|
approved however, I'm wondering whether a better design is to define the skills protocol as not sending typing indicators i.e. contain this logic in the turncontext.send/adapter that is a stronger (and correct) statement, simplifies this code, and means you can't accidentally write your own typing indicators and expect them to be sent to a parent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4478
(Note: this PR also the changes suggested to the solution submited by @sschutten in #4479)