Skip to content

Update BotFrameworkAdapter, Fixes : #4710 #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Update BotFrameworkAdapter, Fixes : #4710 #4711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b13de4e
Update BotFrameworkAdapter to fix Fixes: #4710
godwin3737 Sep 25, 2020
b613f5c
Updated for culture sensitive method calls
godwin3737 Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Net;
using System.Net.Http;
Expand Down Expand Up @@ -530,7 +531,7 @@ public override async Task<ResourceResponse[]> SendActivitiesAsync(ITurnContext
{
// The Activity Schema doesn't have a delay type built in, so it's simulated
// here in the Bot. This matches the behavior in the Node connector.
var delayMs = (int)activity.Value;
var delayMs = Convert.ToInt32(activity.Value, CultureInfo.InvariantCulture);
await Task.Delay(delayMs, cancellationToken).ConfigureAwait(false);

// No need to create a response. One will be created below.
Expand Down