Hide DialogInspector and centralize resetting retries #4715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlm
reviewed
Sep 25, 2020
| @@ -85,7 +85,7 @@ public virtual void ValidateReply(Activity activity) | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public override async Task ExecuteAsync(TestAdapter adapter, BotCallbackHandler callback, DialogInspector inspector) | |||
| public override async Task ExecuteAsync(TestAdapter adapter, BotCallbackHandler callback, Inspector inspector) | |||
There was a problem hiding this comment.
Inspector inspector [](start = 98, length = 19)
can you make this optional? =null?
added 2 commits
September 25, 2020 19:25
Add description to memory assertions. Redo retries tests to work with new retries model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Tom's review feedback. This hides DialogInspector behind a delegate to reduce surface area and moves resetting retries from memory modification to when events are emitted making it simpler and clearer.