additional values in the issuers list #4857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So for now I've added a comment to the CloudAdapter implementation. This is a little academic as we are making no claim for skills working with CloudAdapter yet and there are a few other moving parts that would have to be in place. However, it would be good to understand the implications for emulator validation. @willportnoy can you comment. Should the enumlator validation in the ParameterizedBotFrameworkAuthentication class use the same [single] value as the channel validation? |
gabog
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SkillsValidation class also contains the list of issuers and should be the same as the EmulatorValidators array.
And as a separate issue - these should surely share some code - however that can be addressed in the internals of the CloudAdapter auth implementation.