Update disabled property to booleanExpression in Microsoft.SendActivity.schema #4923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimc62
approved these changes
Nov 5, 2020
cleemullins
requested changes
Nov 5, 2020
There was a problem hiding this comment.
@luhan2017 Can you please update the PR? IT needs an Issue, and the template needs to be filled out. We need to hold a higher bar on PR quality.
@cleemullins Thanks for the reminder, updated the contents, I refer this to a composer issue, should I create a issue in dotnet repo for this? |
cleemullins
approved these changes
Nov 6, 2020
chrimc62
pushed a commit
that referenced
this pull request
Nov 6, 2020
Merged
mrivera-ms
pushed a commit
that referenced
this pull request
Nov 6, 2020
* Fix broken help links in uischema files (#4911) * Update Microsoft.LogAction.uischema * fix broken links * add OnChooseIntent uischema (#4914) * Update Microsoft.SendActivity.schema (#4923) * Update test schemas. Co-authored-by: zxyanliu <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: Lu Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/BotFramework-Composer#4651
Description
Composer is assuming disable property to be booleanExpression across all the kinds.
But currently in sdk, in SendActivity and Ask action, the disable property is defined as a StringExpression which breaks composer's assumption and the disable feature for SendActivity and Ask action is not working now.
Disabling the two actions will get an validation error.
Specific Changes
Testing
Tested in composer UX, update the schema will fix this issue.