Skip to content

Added DeliveryMode bufferedReplies #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2020
Merged

Added DeliveryMode bufferedReplies #812

merged 6 commits into from
Mar 4, 2020

Conversation

tracyboehrer
Copy link
Member

Fixes #781

@tracyboehrer tracyboehrer requested a review from johnataylor March 3, 2020 14:44
johnataylor
johnataylor approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But we probably want a Python expert to take a second look.

@tracyboehrer
Serializing the InvokeResponse.body when DeliveryMode == bufferedRepl…
4969015 
…ies. Added method to BotFrameworkHttpClient to deserialized bufferedReplies for the caller.
@tracyboehrer tracyboehrer requested a review from axelsrz March 4, 2020 14:36
@tracyboehrer tracyboehrer merged commit 07692fc into master Mar 4, 2020
@tracyboehrer tracyboehrer deleted the trboehre/bufferedReplies branch March 4, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@axelsrz axelsrz Awaiting requested review from axelsrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skills can handle request/response from custom adapters & directline speech (Python)
2 participants
@tracyboehrer @johnataylor