Skip to content

Conversation

frank-msodsp
Copy link
Contributor

@frank-msodsp frank-msodsp commented Sep 11, 2025

Add JNI support for san
fix san jni with improper use of c_str
Added san support to logmanager

@frank-msodsp frank-msodsp requested a review from a team as a code owner September 11, 2025 11:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds sanitizer support to the LogManager by integrating sanitizer functionality alongside the existing signals capability. The implementation follows the same pattern as the existing signals integration.

  • Adds sanitizer header inclusion and conditional compilation support
  • Implements native JNI methods for registering/unregistering sanitizer on both default and instance LogManagers
  • Exposes sanitizer registration methods in the Java interface and implementation classes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
lib/jni/LogManager_jni.cpp Adds sanitizer header includes and implements four new JNI methods for sanitizer registration/unregistration
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/LogManagerProvider.java Implements sanitizer registration methods in the LogManagerProvider implementation
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/LogManager.java Adds static methods for sanitizer registration on the default LogManager
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/ILogManager.java Adds sanitizer registration method signatures to the interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@frank-msodsp frank-msodsp marked this pull request as draft September 11, 2025 12:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@frank-msodsp frank-msodsp marked this pull request as ready for review September 15, 2025 13:36
Copy link
Contributor

@nishchith-cp nishchith-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Android for Teams application

@lalitb
Copy link
Contributor

lalitb commented Sep 16, 2025

@ThomsonTan - Probably we need force merge as CI failure is unrelated, while we are looking into CI failure?

@ThomsonTan ThomsonTan merged commit 0c83b55 into main Sep 16, 2025
11 of 27 checks passed
@ThomsonTan ThomsonTan deleted the frank/updatelogmanager branch September 16, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants