Skip to content

Support restartInstance and add restartPostUri in HttpManagementPayload #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 7, 2023
Merged

Support restartInstance and add restartPostUri in HttpManagementPayload #125

merged 6 commits into from
Jul 7, 2023

Conversation

kamperiadis
Copy link
Contributor

@kamperiadis kamperiadis commented Mar 21, 2023 •
edited
Loading

Issue describing the changes in this PR

Resolves #108
With these changes, we now support restartInstance and we pass the restartPostUri, resumePostUri and suspendPostUri values in the HttpManagementPayload

Pull request checklist

  • My changes do not require documentation changes
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

@kamperiadis kamperiadis mentioned this pull request Mar 30, 2023
Open
4 tasks
kaibocai
kaibocai approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@kaibocai kaibocai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We may need to wait for durable extension 2.9.4 is in extension bundle before merge this PR, so it will not be included in next release we plan for durable extension 2.9.3 (support rewind and suspend/resume).

kaibocai
kaibocai approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@kaibocai kaibocai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kamperiadis kamperiadis merged commit 57133bd into microsoft:main Jul 7, 2023
@kamperiadis kamperiadis deleted the kamperiadis/restartInstance branch July 7, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaibocai kaibocai kaibocai approved these changes

@cgillum cgillum Awaiting requested review from cgillum

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API to restart an orchestration instance
2 participants
@kamperiadis @kaibocai