This repository was archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Typings: correct typings to match propTypes #548
Comments
An example of failed build #549. |
It's not clear to me what will be done with these changes in I think that for now the best option for us will be use |
DefinitelyTyped/DefinitelyTyped#30730 (comment) The problem is with types difference. |
Proposed solution: type Optional<T> = T | null | undefined -interface CProps {
- required?: boolean
- type?: string
-}
+interface CProps {
+ required: Optional<boolean>
+ type: Optional<string>
+} |
We decided to go with: type Nullable<T> = T | null -interface CProps {
- required?: boolean
- type?: string
-}
+interface CProps {
+ required: Nullable<boolean>
+ type: Nullable<string>
+} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
The latest release of @types/react with TS 3.2 breaks all our builds on Project Tests stage.
Steps
Build any PR.
Expected Result
CI pass.
Actual Result
The text was updated successfully, but these errors were encountered: