This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(useStyles): avoid creating new instances of mergedStyles if there are no inline overrides #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason and
miroslavstastny
as code owners
-no caching added if some of the prop of the hash obj is function
Perf comparison
Generated by 🚫 dangerJS |
# Conflicts: # packages/react/src/utils/renderComponent.tsx
mnajdova
commented
Jan 17, 2020
| props.styles && withDebugId({ root: props.styles } as ComponentSlotStylesInput, 'props.styles'), | ||
| animationStyles && withDebugId({ root: animationStyles }, 'props.animation'), | ||
| ) | ||
| let mergedStyles: ComponentSlotStylesPrepared = theme.componentStyles[displayName] || { |
There was a problem hiding this comment.
As the theme is immutable, the mergedStyles by default will always reference to the same object.
mnajdova
commented
Jan 17, 2020
mnajdova
commented
Jan 17, 2020
| animationStyles && withDebugId({ root: animationStyles }, 'props.animation'), | ||
| ) | ||
| let mergedStyles: ComponentSlotStylesPrepared = theme.componentStyles[displayName] || { | ||
| root: () => ({}), |
There was a problem hiding this comment.
This is necessary for the components that don't have any styles in the theme. It is always a new object, but it should be ok as we don't have anything to cache anyway
mnajdova
changed the title
mnajdova
changed the title
silviuaavram
approved these changes
Jan 17, 2020
# Conflicts: # packages/react-bindings/src/styles/getStyles.ts
layershifter
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved
useStyles, to avoid creating new instances ofmergedStylesif there are no inline overrides.