chore: Remove src, test, build, docs path aliases #2233
Conversation
ecraig12345
requested review from
dvdzkwsk,
dzearing,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
|
| import { mountWithProviderAndGetComponent, mountWithProvider } from 'test/utils' | ||
| import { UIComponent } from 'src/utils' | ||
| import { mountWithProviderAndGetComponent, mountWithProvider } from '../../utils' | ||
| import { UIComponent } from '@fluentui/react/src/utils' |
There was a problem hiding this comment.
| import { UIComponent } from '@fluentui/react/src/utils' | |
| import { UIComponent } from '../../src/utils' |
Can we use instead for unexported things?
There was a problem hiding this comment.
I think it's kind of strange to have a combination of relative path imports and package name imports into the same code, and it might not be clear to a developer coming into the code which import type to use when. (Though you could make the same argument about clarity with when to use @fluentui/react vs paths like @fluentui/react/src/whatever.)
| import { mountWithProvider } from 'test/utils' | ||
| import { Props, PropsOf, InstanceOf } from 'src/types' | ||
| import { mountWithProvider } from '../../utils' | ||
| import { Props, PropsOf, InstanceOf } from '@fluentui/react/src/types' |
There was a problem hiding this comment.
| import { Props, PropsOf, InstanceOf } from '@fluentui/react/src/types' | |
| import { Props, PropsOf, InstanceOf } from '../../src/types' |
Same thing...
packages/react/test/specs/commonTests/implementsWrapperProp.tsx
Outdated
Show resolved
Hide resolved
|
Build failure (at least one of them) is because somehow the generated .d.ts is now using relative paths for inferred types?? This is CarouselNavigation.d.ts before and after: |
build/tsconfig.docs.json
Outdated
| @@ -3,10 +3,7 @@ | |||
| "compilerOptions": { | |||
| "module": "esnext", | |||
| "paths": { | |||
There was a problem hiding this comment.
paths can be removed there
There was a problem hiding this comment.
Can you please also check include. I don't think that we should include react anymore
This reverts commit 26b95d0.
Looks like. And we don't have any ideas why it happens, it's insane 💣 Can you please try tomerge latest |
ecraig12345
force-pushed
the
chore/remove-src-paths-2
branch
from
0ff4a1d to
e17385f
Compare
I think it was somehow introduced by this set of changes...not sure how. I'm going to work on getting an isolated repro. |
|
Closing this down and splitting the changes. |
Replace legacy path aliases with more standard imports:
srcwith@fluentui/reacteverywhere.@fluentui/react/src. I don't think this should create problems since those imports are only used in tests and docs, but please let me know if that's wrong.testwith relative pathsbuildwith relative paths (a couple to be changed to@fluentui/internal-toolingonce chore: Everybody gets a package #2218 is done)docsindocsproject with relative pathsbuild/gulp/plugins/utilimport fromdocs/src/types. For now, add a file in that directory which re-exports the types (imported by relative path) and update all imports to be from that file. Eventually the types should move to a shared location.docsimports inperfandperf-testwith relative path imports, to be removed once the@fluentui/docspackage is added in chore: Everybody gets a package #2218reactandaccessibilityimport generated files which currently live underdocs(componentInfo,behaviorInfo). These imports have to stay as path imports for now because having those packages depend on@fluentui/docswould cause circular imports. So we need a better all-up solution for where these generated files and/or the tests that rely on them should live (or get rid of the generated files?).