This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(menu): color prop #712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
mnajdova
reviewed
Jan 14, 2019
mnajdova
reviewed
Jan 14, 2019
| import { getSideArrow } from '../../utils' | ||
| import { pxToRem } from '../../../../lib' | ||
| import { ComponentSlotStyleFunction, ComponentSlotStylesInput, ICSSInJSStyle } from '../../../types' | ||
| import { pxToRem, getColorFromScheme } from '../../../../lib' |
There was a problem hiding this comment.
I remember I used getColorFromScheme in the renderComponent, so that the user will receive colors object in the styles containing the merged colors. Please take a look on that. If that is not sufficient, we may rework the mechanism there and try to avoid this method in the styles.
There was a problem hiding this comment.
not relevant anymore, see #756
mnajdova
reviewed
Jan 14, 2019
| /> | ||
| ) | ||
|
|
||
| export default MenuExampleColor |
There was a problem hiding this comment.
This example looks overcomplicated to me, may be we can:
- introduce a new
Selectknob - use it to get select an active color
There was a problem hiding this comment.
@layershifter can you show me an example of that? I would give it a shot
docs/src/examples/components/Menu/Variations/MenuExampleVerticalPointingEnd.shorthand.tsx
Show resolved
Hide resolved
codepretty
reviewed
Jan 14, 2019
codepretty
reviewed
Jan 14, 2019
|
closing in favor of #756 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(menu): color prop
Description
This PR:
colorprop toMenucomponentMenucolor examplesAPI
where
COLORcan be:'primary' | 'secondary' | 'blue' | 'green' | 'grey' | 'orange' | 'pink' | 'purple' | 'teal' | 'red' | 'yellow' | string'foreground' | 'background' | 'border'to identify the target area of the componente.g.:
renders:
List of colored menu examples: