Skip to content

Conversation

ElectNewt
Copy link
Contributor

Pull Request

📖 Description

I was testing the sample and I noticed that the page ListBoxOption was crashing. this is due to the component FluentOption should have an ancestor FluentSelect, FluentListBox or FluentComboBox, so I wraped all of the FluentOption into different FluentSelect

🎫 Issues

--

👩‍💻 Reviewer Notes

📑 Test Plan

Nothing really, I just ran the code and went into the sample page

✅ Checklist

General

  • I have added tests for my changes.
  • [x ] I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • [ x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

I noticed that the option Selected="true" for a default value is not working, neither it does in FluentListBox or FluentComboBox;
example:

<FluentSelect>
	<FluentOption>Option 1</FluentOption>
	<FluentOption Selected="true">This option is selected by default.</FluentOption>
</FluentSelect>

It does have Option 1 as default one.

I couldnt see any issue created but at the same time I am not sure if you guys have track of issues in your project in MS or jsut here in github. I did not created it because of that reason.

@ghost
Copy link

ghost commented Nov 11, 2021

CLA assistant check
All CLA requirements met.

vnbaaij added a commit that referenced this pull request Nov 16, 2021
@EisenbergEffect EisenbergEffect merged commit 9f307f7 into microsoft:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants