fix the access to ListboxOptionPage #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
I was testing the sample and I noticed that the page
ListBoxOption
was crashing. this is due to the component FluentOption should have an ancestor FluentSelect, FluentListBox or FluentComboBox, so I wraped all of theFluentOption
into differentFluentSelect
🎫 Issues
--
👩💻 Reviewer Notes
📑 Test Plan
Nothing really, I just ran the code and went into the sample page
✅ Checklist
General
Component-specific
⏭ Next Steps
I noticed that the option
Selected="true"
for a default value is not working, neither it does in FluentListBox or FluentComboBox;example:
It does have
Option 1
as default one.I couldnt see any issue created but at the same time I am not sure if you guys have track of issues in your project in MS or jsut here in github. I did not created it because of that reason.