-
Notifications
You must be signed in to change notification settings - Fork 446
(feature) Project templates #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. A couple of questions:
- Should we simplify the started templates or do you feel it's necessary to have such a "full" starter kit?
- Should we change the package name to maybe be something more like
Microsoft.Fast.Templates.FluentUI.BlazorWebAssembly
? - Do we need to do anything with our publish process to ensure these additional packages get published?
Can you elaborate? The templates are a 'translation' of what you get when you do 'File->New' for a Blazor project
Yes! I'll add this in a new commit to this PR
I'll look into that |
For the template content, if that's the same as Thanks @vnbaaij ! |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
In csproj select highest stable available version of FluentUI package
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
Change description Include generated packages
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
The packages only need to be re-created when the template sources are changed/updated. This is a manual step (see the With my latest changes the latest stable version in the 1.* range of the Fluent UI package should be installed when creating a project. This further reduce the need to update the templates frequently. The generated NuGet template packages are included in the |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
@awentzel Can you take a look at this when you get a chance? This PR will add two new packages that we'd want to publish, which enable starter templates through Visual Studio and the CLI. I wasn't sure if our publish pipeline and steps would handle multiple packages or if we needed to modify things. |
@EisenbergEffect I'll investigate, as I'm unclear as well. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
@awentzel let me know if you want to do a call on this to let me explain the details |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net |
Pull Request
📖 Description
This PR adds templates to the toolkit that allow you to start a new Blazor Server or Blazor WebAssembly project with all the needed changes to use the Fluent UI component library already in place
🎫 Issues
Addresses #88
👩💻 Reviewer Notes
When merging this in, we need to update the general readme to point to these templates and describe how to set them up
📑 Test Plan
Go through provided readme and see if steps needed are clear.
✅ Checklist
General
⏭ Next Steps
Once the PR #142 is merged in we need to update the templates and generate/upload new NuGet packages (instructions provided in
templates/readme.md