Skip to content

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Jan 4, 2022

Pull Request

📖 Description

This PR adds templates to the toolkit that allow you to start a new Blazor Server or Blazor WebAssembly project with all the needed changes to use the Fluent UI component library already in place

🎫 Issues

Addresses #88

👩‍💻 Reviewer Notes

When merging this in, we need to update the general readme to point to these templates and describe how to set them up

📑 Test Plan

Go through provided readme and see if steps needed are clear.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Once the PR #142 is merged in we need to update the templates and generate/upload new NuGet packages (instructions provided in templates/readme.md

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

@vnbaaij vnbaaij changed the title Templates feature: project templates Jan 4, 2022
@vnbaaij vnbaaij changed the title feature: project templates (feature) Project templates Jan 6, 2022
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. A couple of questions:

  • Should we simplify the started templates or do you feel it's necessary to have such a "full" starter kit?
  • Should we change the package name to maybe be something more like Microsoft.Fast.Templates.FluentUI.BlazorWebAssembly?
  • Do we need to do anything with our publish process to ensure these additional packages get published?

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 2, 2022

I like this. A couple of questions:

  • Should we simplify the started templates or do you feel it's necessary to have such a "full" starter kit?

Can you elaborate? The templates are a 'translation' of what you get when you do 'File->New' for a Blazor project

  • Should we change the package name to maybe be something more like Microsoft.Fast.Templates.FluentUI.BlazorWebAssembly?

Yes! I'll add this in a new commit to this PR

  • Do we need to do anything with our publish process to ensure these additional packages get published?

I'll look into that

@EisenbergEffect
Copy link
Contributor

I like this. A couple of questions:

  • Should we simplify the started templates or do you feel it's necessary to have such a "full" starter kit?

Can you elaborate? The templates are a 'translation' of what you get when you do 'File->New' for a Blazor project

  • Should we change the package name to maybe be something more like Microsoft.Fast.Templates.FluentUI.BlazorWebAssembly?

Yes! I'll add this in a new commit to this PR

  • Do we need to do anything with our publish process to ensure these additional packages get published?

I'll look into that

For the template content, if that's the same as File->New Blazor then let's leave that as is. We want it to feel familiar for Blazor devs as much as possible.

Thanks @vnbaaij !

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

In csproj select highest stable available version of FluentUI package
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

Change description
Include generated packages
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 3, 2022

  • Do we need to do anything with our publish process to ensure these additional packages get published?

The packages only need to be re-created when the template sources are changed/updated. This is a manual step (see the readme file in the \templates folder). After that they need to be uploaded to NuGet. I'm not sure how much of that can be automated and if it is worth the hassle.

With my latest changes the latest stable version in the 1.* range of the Fluent UI package should be installed when creating a project. This further reduce the need to update the templates frequently.

The generated NuGet template packages are included in the \templates folder. Once tested and approved they can be made available on NuGet. Instructions on how to install, use and uninstall are in the the readme file in the \templates folder

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 3, 2022

Result in VS after installing templates:
image

Result in browser after using Server template:
image

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

@EisenbergEffect
Copy link
Contributor

@awentzel Can you take a look at this when you get a chance? This PR will add two new packages that we'd want to publish, which enable starter templates through Visual Studio and the CLI. I wasn't sure if our publish pipeline and steps would handle multiple packages or if we needed to modify things.

@awentzel
Copy link
Contributor

awentzel commented Feb 17, 2022

@awentzel Can you take a look at this when you get a chance? This PR will add two new packages that we'd want to publish, which enable starter templates through Visual Studio and the CLI. I wasn't sure if our publish pipeline and steps would handle multiple packages or if we needed to modify things.

@EisenbergEffect I'll investigate, as I'm unclear as well.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 17, 2022

@awentzel let me know if you want to do a call on this to let me explain the details

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-145.centralus.azurestaticapps.net

@awentzel awentzel merged commit 021f3d0 into main Mar 2, 2022
@awentzel awentzel deleted the templates branch March 2, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants