(Bug Fix) Base Layer Luminance was culture related #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
EisenbergEffect
requested review from
EisenbergEffect,
vnbaaij and
nicholasrice
EisenbergEffect
approved these changes
Jan 10, 2022
vnbaaij
approved these changes
Jan 10, 2022
|
Thanks @Eweol ! Sorry for the delay in getting this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The BaseLayerLuminance parameter in the FluentDesignSystemProvider was a culture related float value, which leads to the problem that browsers with a region that uses comma instead of dot for float/double values set the value with comma instead of dot in the html tag.
This leads to unexpected colours in Component.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
Open the example page on a browser which is set to a region which uses comma instead of dot float/double values (German for example) and trigger the Light / Dark Toggle (I have set it from 0 to 0.2 to test it)!
✅ Checklist
General
Component-specific