Skip to content

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Oct 27, 2021

Pull Request

📖 Description

This PR adds a new demo sites setup. Now there are both a Blazor Server demo project and a Blazor Web Assembly demo project. They both reference a Shared project that contains the actual pages, layout an navigation menu. The sites now uses a much simpler mechanism for testing the components by using actual pages.

A working version of the Web Assembly demo can be found at https://thankful-island-0494bc003.azurestaticapps.net/

🎫 Issues

This fulfills #65

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Host the Web Assembly project on an Azure Static Web App.

@EisenbergEffect
Copy link
Contributor

@vnbaaij Ready for a review on this? Any reason to wait or should we get this in now?

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Oct 28, 2021

Yes, good to go as far as I think

@EisenbergEffect EisenbergEffect self-requested a review November 1, 2021 13:13
@EisenbergEffect
Copy link
Contributor

@awentzel Can you review this with top priority? I'd like to get this merged asap with deadlines looming. In particular, have a look at the static web apps config and let's see if we can make that happen.

@awentzel
Copy link
Contributor

awentzel commented Nov 1, 2021

@awentzel Can you review this with top priority? I'd like to get this merged asap with deadlines looming. In particular, have a look at the static web apps config and let's see if we can make that happen.

It looks like @vnbaaij is using the default behavior upon the creation of static web apps so this should just work. Once this PR goes in we should be able to see the link in future PRs. I'll keep an eye on it but looks good.

I do need to add the secret to the repo. I can work with @vnbaaij to create this.

@awentzel awentzel merged commit 7eb671d into microsoft:main Nov 1, 2021
@vnbaaij vnbaaij deleted the new-demo branch November 1, 2021 19:54
@awentzel awentzel mentioned this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants