fix(react): migrate tests from react-test-renderer to @testing-library/react and resolve React 19 issues #35314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
added
Area: Testing
Fluent UI react (v8)
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dmytrokirpa
force-pushed
the
chore/migrate-react-v8-to-rtl
branch
from
0763312 to
3731080
Compare
dmytrokirpa
force-pushed
the
chore/migrate-react-v8-to-rtl
branch
from
3731080 to
9e1ff67
Compare
dmytrokirpa
changed the title
dmytrokirpa
changed the title
dmytrokirpa
commented
Oct 15, 2025
| // if props changed (as opposed to a state update), set the value | ||
| // TODO: switch to strict controlled pattern instead | ||
| if (prevProps !== this.props && this.props.value !== undefined) { | ||
| if (prevProps.value !== this.props.value && this.props.value !== undefined) { |
There was a problem hiding this comment.
Fix inifite loop in React 19
There was a problem hiding this comment.
this is great fix ! this most probably aslo affected users runtime with R17,18
dmytrokirpa
commented
Oct 15, 2025
| const { container, getByLabelText } = render(<DatePickerBase />); | ||
| const input = container.querySelectorAll('div')[5]; | ||
|
|
||
| it('renders Calendar with provided props and custom formatter', () => { |
There was a problem hiding this comment.
moved to a separate file DatePicker.CalendarMock.test.tsx to be able to mock the Calendar component to verify its props with RTL
dmytrokirpa
commented
Oct 15, 2025
| public componentDidUpdate(prevProps: Readonly<IColorPickerProps>, prevState: Readonly<IColorPickerState>): void { | ||
| // if props changed (as opposed to a state update), update the color | ||
| if (prevProps !== this.props) { | ||
| if (prevProps.color !== this.props.color) { |
There was a problem hiding this comment.
Fix infinite loop in React 19
dmytrokirpa
force-pushed
the
chore/migrate-react-v8-to-rtl
branch
from
9e1ff67 to
5b58fb0
Compare
dmytrokirpa
commented
Oct 15, 2025
| "@fluentui/example-data": "*", | ||
| "@fluentui/jest-serializer-merge-styles": "*", | ||
| "@fluentui/react-conformance": "*", | ||
| "@fluentui/test-utilities": "*", |
There was a problem hiding this comment.
the package is not used anymore
dmytrokirpa
requested review from
a team,
Jahnp,
ThomasMichon,
dzearing,
khmakoto and
spmonahan
as code owners
Hotell
approved these changes
Oct 16, 2025
| // if props changed (as opposed to a state update), set the value | ||
| // TODO: switch to strict controlled pattern instead | ||
| if (prevProps !== this.props && this.props.value !== undefined) { | ||
| if (prevProps.value !== this.props.value && this.props.value !== undefined) { |
There was a problem hiding this comment.
this is great fix ! this most probably aslo affected users runtime with R17,18
Updated the type from 'none' to 'patch' to reflect the nature of the changes.
Hotell
reviewed
Oct 16, 2025
| input.props.onClick(); | ||
| }); | ||
| // open the datepicker then dismiss | ||
| await userEvent.click(input); |
There was a problem hiding this comment.
seems like hallucination. the version of user-event we use has not async methods.
- we are on v13
- v14 has all async https://github.com/testing-library/user-event/releases/tag/v14.0.0
There was a problem hiding this comment.
a few tests 458045f#diff-a7e2503f10a441adc194a14a0d703cca90431d7f8ad97951622408f0ce7cb0a2L217 had { delay: 100 } which made the userEvent.type async. So we need to use awaits for those, or remove the delay
I removed delay and awaits in 458045f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
@fluentui/react's tests previously usedreact-test-renderer, which is now deprecated, making them unsuitable for React 19 integration testing.The main test errors encountered during React 19 integration were:
console.error] react-test-renderer is deprecatedError: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops. at getRootForUpdatedFiberCan't access .root on unmounted test rendererNew Behavior
react-test-rendererto@testing-library/react, addressing the first and third issues.ColorPickercomponent'scomponentDidUpdate.@fluentui/reactpackage.Related Issue(s)