-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Dialog, Card & Button have Figma code connect files for v1 testing #35327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@miceclavea please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
📊 Bundle size report✅ No changes found |
@@ -0,0 +1,13 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Drawer 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Drawer.overlay drawer full.chromium.png | 1142 | Changed |
vr-tests-react-components/Positioning 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Positioning.Positioning end.chromium.png | 954 | Changed |
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 710 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - Dark Mode.default.chromium.png | 2 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1321 | Changed |
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
vr-tests-web-components/Avatar 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png | 10381 | Changed |
vr-tests-web-components/Badge 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 444 | Changed |
vr-tests-web-components/MenuList 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
vr-tests/Callout 11 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Callout.Bottom center.default.chromium.png | 2116 | Changed |
vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2186 | Changed |
vr-tests/Callout.Left bottom edge.default.chromium.png | 3123 | Changed |
vr-tests/Callout.Bottom right edge - RTL.default.chromium.png | 1114 | Changed |
vr-tests/Callout.Bottom right edge.default.chromium.png | 1120 | Changed |
vr-tests/Callout.Left center.default.chromium.png | 2544 | Changed |
vr-tests/Callout.Right bottom edge.default.chromium.png | 3037 | Changed |
vr-tests/Callout.Left top edge.default.chromium.png | 2168 | Changed |
vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
vr-tests/Callout.Right center.default.chromium.png | 2080 | Changed |
vr-tests/Callout.Root.default.chromium.png | 2181 | Changed |
vr-tests/Coachmark 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Coachmark.Collapsed.default.chromium.png | 159 | Changed |
vr-tests/Keytip 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Keytip.Disabled.default.chromium.png | 26 | Changed |
vr-tests/react-charting-LineChart 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-LineChart.Events - Dark Mode.default.chromium.png | 16 | Changed |
vr-tests/react-charting-LineChart.Events - RTL.default.chromium.png | 15 | Changed |
vr-tests/react-charting-MultiStackBarChart 4 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-MultiStackBarChart.Basic_Absolute - Dark Mode.default.chromium.png | 363 | Changed |
vr-tests/react-charting-MultiStackBarChart.Basic_PartToWhole - RTL.default.chromium.png | 343 | Changed |
vr-tests/react-charting-MultiStackBarChart.Basic_Absolute - RTL.default.chromium.png | 343 | Changed |
vr-tests/react-charting-MultiStackBarChart.Basic_PartToWhole - Dark Mode.default.chromium.png | 363 | Changed |
vr-tests/react-charting-VerticalBarChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
Thanks for PR, could you provide please more context what is this PR about ? ty |
Previous Behavior
New Behavior
Related Issue(s)