Still sync Task after FrameworkAttempt Completing

pkg/apis/frameworkcontroller/v1/funcs.go

@@ -192,6 +192,18 @@ func (ts *TaskStatus) IsRunning() bool {
 	return ts.State == TaskAttemptRunning
 }
 
+func (f *Framework) IsCompleting() bool {
+	return f.Status.State == FrameworkAttemptDeletionPending ||
+			f.Status.State == FrameworkAttemptDeletionRequested ||
+			f.Status.State == FrameworkAttemptDeleting
+}
+
+func (ts *TaskStatus) IsCompleting() bool {
+	return ts.State == TaskAttemptDeletionPending ||
+			ts.State == TaskAttemptDeletionRequested ||
+			ts.State == TaskAttemptDeleting
+}
+
 func (ct CompletionType) IsSucceeded() bool {
 	return ct.Name == CompletionTypeNameSucceeded
 }
@@ -507,7 +519,8 @@ func (rp RetryPolicySpec) ShouldRetry(
 
 	// 0. Built-in Always-on RetryPolicy
 	if cs.Code == CompletionCodePodSpecInvalid ||
-			cs.Code == CompletionCodeStopFrameworkRequested {
+			cs.Code == CompletionCodeStopFrameworkRequested ||
+			cs.Code == CompletionCodeFrameworkAttemptCompletion {
 		return RetryDecision{false, true, 0, cs.Diagnostics}
 	}
 

pkg/apis/frameworkcontroller/v1/types.go

@@ -132,7 +132,9 @@ const (
 //    complete a single Task in the TaskRole.
 //
 // Usage:
-// If the Pod Spec is invalid or the ExecutionType is ExecutionStop,
+// If the Pod Spec is invalid or
+// the ExecutionType is ExecutionStop or
+// the Task's FrameworkAttempt is completing,
 //   will not retry.
 //
 // If the FancyRetryPolicy is enabled,
@@ -506,7 +508,6 @@ const (
 	// must have been creation requested successfully and is expected to exist.
 	// [AssociatedState]
 	// -> TaskAttemptPreparing
-	// -> TaskAttemptRunning
 	// -> TaskAttemptDeleting
 	// -> TaskAttemptCompleted
 	TaskAttemptCreationRequested TaskState = "AttemptCreationRequested"