Skip to content

feat:Add -P -y -Y flags #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 8, 2023
Merged

feat:Add -P -y -Y flags #369

merged 8 commits into from
Jun 8, 2023

Conversation

shueybubbles
Copy link
Collaborator

@shueybubbles shueybubbles commented Jun 3, 2023

Fixes #365
Fixes #196
Fixes #362
I've also standardized more of the invalid flag error messages and replaced the default Cobra errors with localizable errors prefixed with Sqlcmd:

Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to commit the updated JSON files after running go generate .\internal\translations\translations.go

@shueybubbles
Copy link
Collaborator Author

shueybubbles commented Jun 6, 2023

@apoorvdeshmukh How do I fix this test?

  {
   name:     "existing key",
   key:      "'-w %d': value must be greater than 8 and less than 65536.",
   expected: "k",
   ok:       true,
  },

In reply to: 1579265257

Copy link
Collaborator

@stuartpa stuartpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@apoorvdeshmukh
Copy link
Contributor

@apoorvdeshmukh How do I fix this test?

  {
   name:     "existing key",
   key:      "'-w %d': value must be greater than 8 and less than 65536.",
   expected: "k",
   ok:       true,
  },

In reply to: 1579265257

I had a look at the test which is failing.
After running the go generate command, the catalog.go gets built and the map is generated again.
The key which the testcase is trying to look for doesn't exist in the map and hence it is failing.
It looks for existing key and then looks for it's index in the dictionary and uses the corresponding data as expected value.
This testcase may need modifications if the index of the key gets changed.

@shueybubbles shueybubbles merged commit 5927d96 into main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants