-
Notifications
You must be signed in to change notification settings - Fork 65
feat:Add -P -y -Y flags #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ueybubbles/365and196
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to commit the updated JSON files after running go generate .\internal\translations\translations.go
@apoorvdeshmukh How do I fix this test? {
name: "existing key",
key: "'-w %d': value must be greater than 8 and less than 65536.",
expected: "k",
ok: true,
}, In reply to: 1579265257 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
I had a look at the test which is failing. |
Fixes #365
Fixes #196
Fixes #362
I've also standardized more of the invalid flag error messages and replaced the default Cobra errors with localizable errors prefixed with
Sqlcmd: