Add Azure Managed Lustre Filesystem Import Job Create #319

KinoriSR · 2025-09-04T19:21:56Z

What does this PR do?

Adds azmcp azuremanagedlustre filesystem import-job create and required testing and docs. [#318]

GitHub issue number?

Issue #318

Pre-merge Checklist

KinoriSR · 2025-09-04T19:32:10Z

Some questions:

I had to tweak/fix some other files such as the test resources deployment script. That is not in the scope for this additional command. For the future, should fixes like that be in a separate PR or part of a PR like this?
After running the tool description script, there were some changes made to other files like the eng\tools\ToolDescriptionEvaluator\prompts.json and eng\tools\ToolDescriptionEvaluator\results.txt. Should those changes be included? Many of the changes were in sections that are not Azure Managed Lustre related. Should I only include changes that are Azure Managed Lustre related?

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

KinoriSR · 2025-09-04T19:54:00Z

Failed live tests are related to the test resources bicep file not creating HSM enabled AMLFS quite yet. This PR for AMLFS create should solve this issue.

@wolfgang-desalvador

alzimmermsft · 2025-09-04T19:41:37Z

docs/azmcp-commands.md

+azmcp azuremanagedlustre filesystem import-job create --subscription <subscription> \
+                                     --resource-group <resource-group> \
+                                     --file-system <filesystem-name> \
+                                     --import-prefixes <prefix1> <prefix2> ... <prefixN> \


Suggested change

--import-prefixes <prefix1> <prefix2> ... <prefixN> \

[--import-prefixes <prefix1> <prefix2> ... <prefixN>] \

Given that this isn't required in the tool call.

alzimmermsft · 2025-09-04T19:42:46Z

...ure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/FileSystemImportJobCreateCommand.cs

+using Azure.Mcp.Tools.AzureManagedLustre.Services;
+using Microsoft.Extensions.Logging;
+
+namespace Azure.Mcp.Tools.AzureManagedLustre.Commands.FileSystem;


Will there be many job-based tools? Might be worth putting this into a sub-namespace of FileSystem given create is too generic of a Name.

alzimmermsft · 2025-09-04T19:44:01Z

...ure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/FileSystemImportJobCreateCommand.cs

+
+    public override string Title => CommandTitle;
+
+    public override ToolMetadata Metadata => new() { Destructive = false, ReadOnly = false };


Wouldn't this be considered a Destructive tool given OverwriteAlways can mutate existing resources

Great point. Updating...

Haven't updated yet. Currently figuring out if we want to remove the Overwrite options to prevent destruction.

alzimmermsft · 2025-09-04T19:44:43Z

...ure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/FileSystemImportJobCreateCommand.cs

+                options.ConflictResolutionMode ?? "OverwriteAlways",
+                options.MaximumErrors ?? -1,


Based on BindOptions are the null-coalescing cases even possible?

alzimmermsft · 2025-09-04T19:56:11Z

...ure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/FileSystemImportJobCreateCommand.cs

+        var options = BindOptions(parseResult);
+        try
+        {
+            if (!Validate(parseResult.CommandResult, context.Response).IsValid)
+            {
+                return context.Response;
+            }


There's an upcoming broad update where Validate should be called before BindOptions, mind updating that here.

Also make sure you rebase with main

jongio · 2025-09-04T22:18:57Z

docs/azmcp-commands.md


 # Returns the required number of IP addresses for a specific Azure Managed Lustre SKU and filesystem size
 azmcp azuremanagedlustre filesystem required-subnet-size --subscription <subscription> \
                                      --sku <azure-managed-lustre-sku> \
                                      --size <filesystem-size-in-tib>
+
+# Create an Azure Managed Lustre filesystem import job (preview / placeholder)
+azmcp azuremanagedlustre filesystem import-job create --subscription <subscription> \


don't include azure in the name

This is a planned refactor which will be addressed after the current PRed actions are in. Here is the open conversion issue: #345 .

Is this a sufficient solution for now?

Please take that as a PR this week, thanks.

jongio · 2025-09-04T22:19:21Z

docs/azmcp-commands.md

+                                     [--conflict-resolution-mode <conflict-mode>] \
+                                     [--maximum-errors <maximum-errors>] \
+                                     [--admin-status <admin-status>] \
+                                     [--job-name <job-name>]


only include -name in option name if required to diff from another name

jongio · 2025-09-04T22:19:49Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/AzureManagedLustreSetup.cs

@@ -22,13 +22,16 @@ public void ConfigureServices(IServiceCollection services)
    public void RegisterCommands(CommandGroup rootGroup, ILoggerFactory loggerFactory)
    {
        var azureManagedLustre = new CommandGroup(Name,
-            "Azure Managed Lustre operations - Commands for listing and inspecting Azure Managed Lustre file systems (AMLFS) used for high-performance computing workloads.");
+            "Azure Managed Lustre operations - Commands for non-destructive interaction with Azure Managed Lustre file systems (AMLFS) used for high-performance computing workloads.");


Simplify this, too many repeated words

jongio · 2025-09-04T22:20:12Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/AzureManagedLustreSetup.cs

        rootGroup.AddSubGroup(azureManagedLustre);

        var fileSystem = new CommandGroup("filesystem", "Azure Managed Lustre file system operations - Commands for listing managed Lustre file systems.");
        azureManagedLustre.AddSubGroup(fileSystem);

        fileSystem.AddCommand("list", new FileSystemListCommand(loggerFactory.CreateLogger<FileSystemListCommand>()));
        fileSystem.AddCommand("required-subnet-size", new FileSystemSubnetSizeCommand(loggerFactory.CreateLogger<FileSystemSubnetSizeCommand>()));
+        var importJob = new CommandGroup("import-job", "AMLFS import job operations - Create manual import jobs to hydrate the file system namespace.");


What is AMLFS IDK if copilot will know that acronym.

AMLFS is Azure Managed Lustre File System. I can expand to words in the next push.

KinoriSR · 2025-09-04T20:08:48Z

...e.Mcp.Tools.AzureManagedLustre.UnitTests/FileSystem/FileSystemImportJobCreateCommandTests.cs

+        Assert.Equal("/", result.ImportJob.ImportPrefixes![0]);
+    }
+
+    // TODO: may need a delay between tests to prevent conflicts with successful jobs


Removing in next push.

KinoriSR · 2025-09-04T20:11:40Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/Services/AzureManagedLustreService.cs

+        IList<string>? importPrefixes = null,
+        string conflictResolutionMode = "OverwriteAlways",
+        int? maximumErrors = 0,
+        string? adminStatus = "Active", // TODO: discuss the necessity of this


@wolfgang-desalvador thoughts on the necessity of this param? It must always be "Active" when creating an import job. Only "Cancel" when canceling the job.

Create and update will be separate commands so remove adminStatus can be hardcoded as "Active".

KinoriSR · 2025-09-08T15:17:22Z

docs/azmcp-commands.md


 # Returns the required number of IP addresses for a specific Azure Managed Lustre SKU and filesystem size
 azmcp azuremanagedlustre filesystem required-subnet-size --subscription <subscription> \
                                      --sku <azure-managed-lustre-sku> \
                                      --size <filesystem-size-in-tib>
+
+# Create an Azure Managed Lustre filesystem import job (preview / placeholder)
+azmcp azuremanagedlustre filesystem import-job create --subscription <subscription> \


This is a planned refactor which will be addressed after the current PRed actions are in. Here is the open conversion issue: #345 .

Is this a sufficient solution for now?

KinoriSR · 2025-09-08T15:22:54Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/AzureManagedLustreSetup.cs

        rootGroup.AddSubGroup(azureManagedLustre);

        var fileSystem = new CommandGroup("filesystem", "Azure Managed Lustre file system operations - Commands for listing managed Lustre file systems.");
        azureManagedLustre.AddSubGroup(fileSystem);

        fileSystem.AddCommand("list", new FileSystemListCommand(loggerFactory.CreateLogger<FileSystemListCommand>()));
        fileSystem.AddCommand("required-subnet-size", new FileSystemSubnetSizeCommand(loggerFactory.CreateLogger<FileSystemSubnetSizeCommand>()));
+        var importJob = new CommandGroup("import-job", "AMLFS import job operations - Create manual import jobs to hydrate the file system namespace.");


AMLFS is Azure Managed Lustre File System. I can expand to words in the next push.

KinoriSR · 2025-09-08T15:23:25Z

...ure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/FileSystemImportJobCreateCommand.cs

+
+    public override string Title => CommandTitle;
+
+    public override ToolMetadata Metadata => new() { Destructive = false, ReadOnly = false };


Great point. Updating...

jongio · 2025-09-08T17:45:46Z

...ure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/FileSystemImportJobCreateCommand.cs

+        var options = BindOptions(parseResult);
+        try
+        {
+            if (!Validate(parseResult.CommandResult, context.Response).IsValid)
+            {
+                return context.Response;
+            }


Also make sure you rebase with main

jongio · 2025-09-08T17:46:15Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/Options/AzureManagedLustreOptionDefinitions.cs

+
+    public static readonly Option<string> FileSystemOption = new(
+        $"--{fileSystem}",
+        "The name of the Azure Managed Lustre file system (AMLFS)."


All of these need to be updated to Required and explicit Description property set

jongio · 2025-09-08T17:48:39Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/Services/AzureManagedLustreService.cs

+        string? tenant = null,
+        RetryPolicyOptions? retryPolicy = null)
+    {
+        ArgumentException.ThrowIfNullOrWhiteSpace(subscription);


Use ValidateRequiredParameters method

jongio · 2025-09-08T17:49:05Z

tools/Azure.Mcp.Tools.AzureManagedLustre/src/Services/AzureManagedLustreService.cs

+            var rg = await _resourceGroupService.GetResourceGroupResource(subscription, resourceGroup, tenant, retryPolicy)
+                ?? throw new Exception($"Resource group '{resourceGroup}' not found");
+
+            var fs = await rg.GetAmlFileSystemAsync(fileSystemName);


IF this takes a handle, then make sure it is disposed

The return object does not seem to be disposable.

xiangyan99 · 2025-09-16T18:10:10Z

...ols.AzureManagedLustre/src/Commands/FileSystem/ImportJob/FileSystemImportJobCreateCommand.cs

+
+    public override string Title => CommandTitle;
+
+    public override ToolMetadata Metadata => new() { Destructive = false, ReadOnly = false };


Please provide values for all hints.

Copilot AI review requested due to automatic review settings September 4, 2025 19:21

KinoriSR requested review from wolfgang-desalvador and a team as code owners September 4, 2025 19:21

github-project-automation bot added this to Azure MCP Server Sep 4, 2025

KinoriSR requested review from joshfree, jongio, vukelich, wbreza, conniey, sandeep-sen and alzimmermsft September 4, 2025 19:21

github-project-automation bot moved this to Untriaged in Azure MCP Server Sep 4, 2025

KinoriSR requested a review from Aman-Jain-14 September 4, 2025 19:23

KinoriSR added the Azure.Mcp.Tools.AzureManagedLustre label Sep 4, 2025

Copilot AI reviewed Sep 4, 2025

View reviewed changes

alzimmermsft reviewed Sep 4, 2025

View reviewed changes

jongio requested changes Sep 4, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Sep 4, 2025

KinoriSR commented Sep 8, 2025

View reviewed changes

jongio requested changes Sep 8, 2025

View reviewed changes

joshfree assigned alzimmermsft Sep 9, 2025

KinoriSR force-pushed the kinorirosnow/amlfs-hsm branch from a4734b0 to 67d1a8f Compare September 11, 2025 20:53

KinoriSR added 5 commits September 16, 2025 10:51

import job create command

1cdb3a8

spellcheck fixes

c2d4507

rename jobName to name

484fc4d

ImportJob namespace

461bf12

fix namespace, parameters, unit tests, deployment scripts

a04e969

KinoriSR force-pushed the kinorirosnow/amlfs-hsm branch from 67d1a8f to a04e969 Compare September 16, 2025 14:57

joshfree removed the Azure.Mcp.Tools.AzureManagedLustre label Sep 16, 2025

KinoriSR added 2 commits September 16, 2025 12:11

unit/live test fixes

9febbd4

format, test fixes

77c099e

xiangyan99 reviewed Sep 16, 2025

View reviewed changes

no need for null coalescing

f99ecd7

joshfree added this to the 2025-09 milestone Sep 16, 2025

alzimmermsft assigned KinoriSR Sep 16, 2025

remove option to do use Overwrite conflict resolution modes

6fad6fb

	--import-prefixes <prefix1> <prefix2> ... <prefixN> \
	[--import-prefixes <prefix1> <prefix2> ... <prefixN>] \


		public override string Title => CommandTitle;

		public override ToolMetadata Metadata => new() { Destructive = false, ReadOnly = false };

		options.ConflictResolutionMode ?? "OverwriteAlways",
		options.MaximumErrors ?? -1,

Add Azure Managed Lustre Filesystem Import Job Create #319

Are you sure you want to change the base?

Add Azure Managed Lustre Filesystem Import Job Create #319

Uh oh!

Conversation

KinoriSR commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

KinoriSR commented Sep 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

KinoriSR commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KinoriSR commented Sep 4, 2025 •

edited

Loading

KinoriSR commented Sep 4, 2025 •

edited

Loading