-
Notifications
You must be signed in to change notification settings - Fork 205
Add azmcp-keyvault-admin-settings-get
for KeyVault.Administration
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azmcp-keyvault-admin-settings-get
for KeyVault.Administration
#358
Conversation
tools/Azure.Mcp.Tools.KeyVault/src/Commands/Admin/AdminSettingsGetCommand.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the first tool for KeyVault Administration (Data Plane): azmcp-keyvault-admin-settings-get
. The command retrieves Key Vault administration settings including purge protection state and soft delete retention days using the Azure.Security.KeyVault.Administration SDK.
- Implements the
azmcp-keyvault-admin-settings-get
command for retrieving Key Vault administration settings - Extends KeyVaultService with new data plane administration functionality
- Adds comprehensive test coverage for the new admin settings command
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
AdminSettingsGetCommandTests.cs | Unit tests for the new admin settings get command |
KeyVaultService.cs | Extended service with GetVaultSettings method using Administration SDK |
IKeyVaultService.cs | Interface extension with new method and VaultSettings record |
AdminSettingsGetOptions.cs | Options class for admin settings command |
KeyVaultSetup.cs | Command registration for admin settings functionality |
KeyVaultJsonContext.cs | JSON serialization context for VaultSettings |
AdminSettingsGetCommand.cs | Implementation of the admin settings get command |
Azure.Mcp.Tools.KeyVault.csproj | Added Azure.Security.KeyVault.Administration package reference |
CHANGELOG.md | Documentation of the new feature |
Directory.Packages.props | Package version management for the new dependency |
tools/Azure.Mcp.Tools.KeyVault/src/Commands/Admin/AdminSettingsGetCommand.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.KeyVault/src/Commands/Admin/AdminSettingsGetCommand.cs
Outdated
Show resolved
Hide resolved
...ools.KeyVault/tests/Azure.Mcp.Tools.KeyVault.UnitTests/Admin/AdminSettingsGetCommandTests.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.KeyVault/src/Commands/KeyVaultJsonContext.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.KeyVault/src/Services/IKeyVaultService.cs
Outdated
Show resolved
Hide resolved
…d-admin-get-settings
…d-admin-get-settings
What does this PR do?
This PR adds the first tool for KeyVault Administration (Data Plane):
azmcp-keyvault-admin-settings-get
GitHub issue number?
Resolves #308
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.md
and/orservers/Fabric.Mcp.Server/CHANGELOG.md
for product changes (features, bug fixes, UI/UX, updated dependencies
)servers/Azure.Mcp.Server/README.md
and/orservers/Fabric.Mcp.Server/README.md
documentation/docs/azmcp-commands.md
and/or/docs/fabric-commands.md
ToolDescriptionEvaluator
and obtained a score of0.4
or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.md
crypto mining, spam, data exfiltration, etc.
)/azp run mcp - pullrequest - live
to run Live Test Pipeline